UNPKG

9.58 kBMarkdownView Raw
1# Contributing to Allons-y project
2
3We'd love for you to contribute to our source code and to make this project even better and fun than it is
4today! Here are the guidelines we'd like you to follow:
5
6 - [Code of Conduct](#coc)
7 - [Question or Problem?](#question)
8 - [Issues and Bugs](#issue)
9 - [Feature Requests](#feature)
10 - [Submission Guidelines](#submit)
11 - [Coding Rules](#rules)
12 - [Commit Message Guidelines](#commit)
13 - [Releases](#releases)
14 - [Further Info](#info)
15
16## <a name="coc"></a> Code of Conduct
17As contributors and maintainers of the project, we pledge to respect everyone who contributes by posting issues, submitting pull requests, providing feedback in comments, and any other activities.
18
19Communication through any of project's channels (GitHub, IRC, mailing lists, Google+, Twitter, etc.) must be constructive and never resort to personal attacks, trolling, public or private harrassment, insults, or other unprofessional conduct.
20
21We promise to extend courtesy and respect to everyone involved in this project regardless of gender, gender identity, sexual orientation, disability, age, race, ethnicity, religion, or level of experience. We expect anyone contributing to the project to do the same.
22
23If any member of the community violates this code of conduct, the maintainers of the project may take action, removing issues, comments, and PRs or blocking accounts as deemed appropriate.
24
25If you are subject to or witness unacceptable behavior, or have any other concerns, please contact us.
26
27## <a name="question"></a> Got a Question or Problem?
28
29Please, do not open issues for the general support questions as we want to keep GitHub issues for bug reports and feature requests. You've got much better chances of getting your question answered on [StackOverflow](stackoverflow.com/questions/tagged/allons-y) where the questions should be tagged with tag `allons-y`.
30
31StackOverflow is a much better place to ask questions since:
32
33- there are thousands of people willing to help on StackOverflow
34- questions and answers stay available for public viewing so your question / answer might help someone else
35- StackOverflow's voting system assures that the best answers are prominently visible.
36
37To save your and our time we will be systematically closing all the issues that are requests for general support and redirecting people to StackOverflow.
38
39If you would like to chat about the question in real-time, you can reach out via [our gitter channel][https://gitter.im/CodeCorico/allons-y].
40
41## <a name="issue"></a> Found an Issue?
42If you find a bug in the source code, you can help us by
43[submitting an issue](#submit-issue) to our [GitHub Repository][https://github.com/CodeCorico/allons-y]. Even better, you can
44[submit a Pull Request](#submit-pr) with a fix.
45
46## <a name="feature"></a> Want a Feature?
47You can request a new feature by submitting an issue to the [GitHub Repository](https://github.com/CodeCorico/allons-y/issues). If you would like to implement a new feature then consider what kind of change it is:
48
49* **Major Changes** that you wish to contribute to the project should be discussed first with us so that we can better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project.
50* **Small Changes** can be crafted and submitted to the [GitHub Repository](https://github.com/CodeCorico/allons-y/pulls) as a Pull Request.
51
52A new issue create a discussion thread. Other contributors can advise and contribute to your ideas. Please search whether the subject does not already exists on the [opened issues](https://github.com/CodeCorico/allons-y/issues?q=is%3Aopen+is%3Aissue) before that to prevent duplicates issues.
53
54## <a name="submit"></a> Submission Guidelines
55
56### <a name="submit-issue"></a> Submitting an Issue
57Before you submit your issue please search the archive, maybe your question was already answered.
58
59If your issue appears to be a bug, and hasn't been reported, open a new issue.
60Help us to maximize the effort we can spend fixing issues and adding new
61features, by not reporting duplicate issues. Providing the following information will increase the
62chances of your issue being dealt with quickly:
63
64* **Overview of the issue** - if an error is being thrown a non-minified stack trace helps
65* **Motivation for or Use Case** - explain why this is a bug for you
66* **Version(s)** - is it a regression?
67* **Browsers and Operating System** - is this a problem with all browsers or only IE8?
68* **Reproduce the error** - provide a live example (using [Plunker](http://plnkr.co) or [JSFiddle](http://jsfiddle.net)) or a unambiguous set of steps.
69* **Related issues** - has a similar issue been reported before?
70* **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit)
71
72**If you get help, help others. Good karma rulez!**
73
74### <a name="submit-prr"></a> Submitting a Pull Request
75Before you submit your pull request consider the following guidelines:
76
77* Search [GitHub pulls](https://github.com/CodeCorico/allons-y/pulls) for an open or closed Pull Request
78 that relates to your submission. You don't want to duplicate effort.
79* Make your changes in a new git branch
80
81 ```shell
82 git checkout -b my-fix-branch master
83 ```
84
85* Create your patch, **including appropriate test cases**.
86* Follow the [Coding Rules](#rules).
87* Commit your changes using a descriptive commit message that follows the
88 [commit message conventions](#commit-message-format).
89
90 ```shell
91 git commit -a
92 ```
93 Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
94
95* Push your branch to GitHub:
96
97 ```shell
98 git push origin my-fix-branch
99 ```
100
101* In GitHub, send a pull request to `allons-y:master`.
102* If we suggest changes then
103 * Make the required updates.
104 * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
105
106 ```shell
107 git rebase master -i
108 git push -f
109 ```
110
111That's it! Thank you for your contribution!
112
113#### After your pull request is merged
114
115After your pull request is merged, you can safely delete your branch and pull the changes
116from the main (upstream) repository:
117
118* Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:
119
120 ```shell
121 git push origin --delete my-fix-branch
122 ```
123
124* Check out the master branch:
125
126 ```shell
127 git checkout master -f
128 ```
129
130* Delete the local branch:
131
132 ```shell
133 git branch -D my-fix-branch
134 ```
135
136* Update your master with the latest upstream version:
137
138 ```shell
139 git pull --ff upstream master
140 ```
141
142## <a name="rules"></a> Coding Rules
143To ensure consistency throughout the source code, keep these rules in mind as you are working:
144
145* All features or bug fixes **must be tested** by one or more contributors.
146
147## <a name="commit"></a> Git Commit Guidelines
148
149We have very precise rules over how our git commit messages can be formatted. This leads to **more
150readable messages** that are easy to follow when looking through the **project history**.
151
152### Commit Message Format
153Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
154format that includes a **type**, a **scope** and a **subject**:
155
156```
157<type>(<scope>): <subject>
158<BLANK LINE>
159<body>
160<BLANK LINE>
161<footer>
162```
163
164Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
165to read on github as well as in various git tools.
166
167### Type
168Must be one of the following:
169
170* **chore**: Modifications on project details (like readme files)
171* **feat**: A new feature
172* **fix**: A bug fix
173* **rules**: Modifications on rules
174* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
175* **refactor**: A code change that neither fixes a bug or adds a feature
176* **perf**: A code change that improves performance
177
178### Scope
179The scope could be anything specifying place of the commit change. For example `feature`,
180`component`, `class`, etc...
181
182### Subject
183The subject contains succinct description of the change:
184
185* use the imperative, present tense: "change" not "changed" nor "changes"
186* don't capitalize first letter
187* no dot (.) at the end
188
189### Body
190Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes"
191The body should include the motivation for the change and contrast this with previous behavior.
192
193### Footer
194The footer should contain any information about **Breaking Changes** and is also the place to
195reference GitHub issues that this commit **Closes**.
196
197## <a name="releases"></a> Releases
198
199Only the lead contribution team can publish a new version. To do that, it requires that the milestone is completely finished ([Milestones](https://github.com/CodeCorico/allons-y/issues/milestones?state=open)).
200
201Publish the new version:
202* Pull the last version of `master` branch
203* Define the new version number (format MAJOR.MINOR.REVISION)
204* Update the `package.json` version
205* Update the `CHANGELOG.md` file with the new changes
206* Commit these changes with `release: 0.0.0`
207* Create a new tag on this commit named `[new version number]` (format: 0.0.0)
208* Push the branch
209* Push the new tag release with ```git push --tags```
210* Publish on NPM with ```npm publish```
211
212## <a name="infos"></a> Further Info
213
214Largely inspired file from https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md
215
\No newline at end of file