1 | # Contributing to Bootstrap Table
|
2 |
|
3 | Looking to contribute something to Bootstrap Table?
|
4 |
|
5 | **Here's how you can help.**
|
6 |
|
7 | Please take a moment to review this document in order to make the contribution
|
8 | process easy and effective for everyone involved.
|
9 |
|
10 | Following these guidelines helps to communicate that you respect the time of
|
11 | the developers managing and developing this open source project. In return,
|
12 | they should reciprocate that respect in addressing your issue or assessing
|
13 | patches and features.
|
14 |
|
15 |
|
16 | ## Using the issue tracker
|
17 |
|
18 | The [issue tracker](https://github.com/wenzhixin/bootstrap-table/issues) is
|
19 | the preferred channel for [bug reports](#bug-reports), [features requests](#feature-requests)
|
20 | and [submitting pull requests](#pull-requests), but please respect the following
|
21 | restrictions:
|
22 |
|
23 | * Please **do not** use the issue tracker for personal support requests. Stack
|
24 | Overflow ([`bootstrap-table`](http://stackoverflow.com/questions/tagged/bootstrap-table) tag is better place to get help).
|
25 |
|
26 | * Please **do not** derail or troll issues. Keep the discussion on topic and
|
27 | respect the opinions of others.
|
28 |
|
29 | * Please **do not** open issues or pull requests regarding the code in [`bootstrap-table-examples`](https://github.com/wenzhixin/bootstrap-table-examples) and [`extensions plugin dependence`](https://github.com/wenzhixin/bootstrap-table/tree/develop/src/extensions) (open them in their respective repositories), the dependence list:
|
30 | * Table Editable: [x-editable](https://github.com/vitalets/x-editable)
|
31 | * Table Export: [tableExport.jquery.plugin](https://github.com/hhurz/tableExport.jquery.plugin)
|
32 | * Table Reorder-Columns: [jquery-ui](https://code.jquery.com/ui/) and [dragTable](https://github.com/akottr/dragtable/)
|
33 | * Table Reorder-Rows: [tablednd](https://github.com/isocra/TableDnD)
|
34 | * Table Resizable: [jquery-resizable-columns](https://github.com/dobtco/jquery-resizable-columns)
|
35 | * Table Treegrid: Dependence: [jquery-treegrid](https://github.com/maxazan/jquery-treegrid) v0.3.0
|
36 |
|
37 |
|
38 | ## Issues and labels
|
39 |
|
40 | Our bug tracker utilizes several labels to help organize and identify issues.
|
41 |
|
42 | For a complete look at our labels, see the [project labels page](https://github.com/wenzhixin/bootstrap-table/labels).
|
43 |
|
44 |
|
45 | ## Bug reports
|
46 |
|
47 | A bug is a _demonstrable problem_ that is caused by the code in the repository.
|
48 | Good bug reports are extremely helpful, so thanks!
|
49 |
|
50 | Guidelines for bug reports:
|
51 |
|
52 | 0. **Validate and lint your code** — [validate your HTML](http://html5.validator.nu)
|
53 | and [lint your HTML](https://github.com/twbs/bootlint) to ensure your
|
54 | problem isn't caused by a simple error in your own code.
|
55 |
|
56 | 1. **Use the GitHub issue search** — check if the issue has already been
|
57 | reported.
|
58 |
|
59 | 2. **Check if the issue has been fixed** — try to reproduce it using the
|
60 | latest `master` or development branch in the repository.
|
61 |
|
62 | 3. **Isolate the problem** — ideally create a live example.
|
63 | Our [Online Editor](https://live.bootstrap-table.com) tool is a very helpful for this.
|
64 |
|
65 |
|
66 | A good bug report shouldn't leave others needing to chase you up for more
|
67 | information. Please try to be as detailed as possible in your report. What is
|
68 | your environment? What steps will reproduce the issue? What browser(s) and OS
|
69 | experience the problem? Do other browsers show the bug differently? What
|
70 | would you expect to be the outcome? All these details will help people to fix
|
71 | any potential bugs.
|
72 |
|
73 | Example:
|
74 |
|
75 | > Short and descriptive example bug report title
|
76 | >
|
77 | > A summary of the issue and the browser/OS environment in which it occurs. If
|
78 | > suitable, include the steps required to reproduce the bug.
|
79 | >
|
80 | > 1. This is the first step
|
81 | > 2. This is the second step
|
82 | > 3. Further steps, etc.
|
83 | >
|
84 | > `<url>` - a link to the reduced test case
|
85 | >
|
86 | > Any other information you want to share that is relevant to the issue being
|
87 | > reported. This might include the lines of code that you have identified as
|
88 | > causing the bug, and potential solutions (and your opinions on their
|
89 | > merits).
|
90 |
|
91 |
|
92 | ## Feature requests
|
93 |
|
94 | Feature requests are welcome. But take a moment to find out whether your idea
|
95 | fits with the scope and aims of the project. It's up to *you* to make a strong
|
96 | case to convince the project's developers of the merits of this feature. Please
|
97 | provide as much detail and context as possible.
|
98 |
|
99 |
|
100 | ## Pull requests
|
101 |
|
102 | Good pull requests—patches, improvements, new features—are a fantastic
|
103 | help. They should remain focused in scope and avoid containing unrelated
|
104 | commits.
|
105 |
|
106 | **Please ask first** before embarking on any significant pull request (e.g.
|
107 | implementing features, refactoring code, porting to a different language),
|
108 | otherwise you risk spending a lot of time working on something that the
|
109 | project's developers might not want to merge into the project.
|
110 |
|
111 | Please adhere to the [coding guidelines](#code-guidelines) used throughout the
|
112 | project (indentation, accurate comments, etc.) and any other requirements
|
113 | (such as test coverage).
|
114 |
|
115 | **Do not edit files of `dist` directly!** Those files are automatically generated. You should edit the
|
116 | source files in [`/src/`](https://github.com/wenzhixin/bootstrap-table/tree/develop/src) instead.
|
117 |
|
118 | Similarly, when contributing to Bootstrap's documentation, you should edit the
|
119 | documentation source files in
|
120 | [the `/site/` directory of the `develop` branch](https://github.com/wenzhixin/bootstrap-table/tree/develop/site).
|
121 |
|
122 | Adhering to the following process is the best way to get your work
|
123 | included in the project:
|
124 |
|
125 | 1. [Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your fork,
|
126 | and configure the remotes:
|
127 |
|
128 | ```bash
|
129 | # Clone your fork of the repo into the current directory
|
130 | git clone https://github.com/<your-username>/bootstrap-table.git
|
131 | # Navigate to the newly cloned directory
|
132 | cd bootstrap-table
|
133 | # Assign the original repo to a remote called "upstream"
|
134 | git remote add upstream https://github.com/wenzhixin/bootstrap-table.git
|
135 | ```
|
136 |
|
137 | 2. If you cloned a while ago, get the latest changes from upstream:
|
138 |
|
139 | ```bash
|
140 | git checkout develop
|
141 | git pull upstream develop
|
142 | ```
|
143 |
|
144 | 3. Create a new topic branch (off the main project development branch) to
|
145 | contain your feature, change, or fix:
|
146 |
|
147 | ```bash
|
148 | git checkout -b <topic-branch-name>
|
149 | ```
|
150 |
|
151 | 4. Commit your changes in logical chunks. Please adhere to these [git commit
|
152 | message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
|
153 | or your code is unlikely be merged into the main project. Use Git's
|
154 | [interactive rebase](https://help.github.com/articles/about-git-rebase/)
|
155 | feature to tidy up your commits before making them public.
|
156 |
|
157 | 5. Locally merge (or rebase) the upstream development branch into your topic branch:
|
158 |
|
159 | ```bash
|
160 | git pull [--rebase] upstream develop
|
161 | ```
|
162 |
|
163 | 6. Push your topic branch up to your fork:
|
164 |
|
165 | ```bash
|
166 | git push origin <topic-branch-name>
|
167 | ```
|
168 |
|
169 | 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
|
170 | with a clear title and description against the `develop` branch.
|
171 |
|
172 | **IMPORTANT**: By submitting a patch, you agree to allow the project owners to
|
173 | license your work under the terms of the [MIT License](LICENSE) (if it
|
174 | includes code changes) and under the terms of the
|
175 | [Creative Commons Attribution 3.0 Unported License](site/LICENSE)
|
176 | (if it includes documentation changes).
|
177 |
|
178 |
|
179 | ## Code guidelines
|
180 |
|
181 | - Readability
|
182 | - [no semicolons](https://github.com/wenzhixin/bootstrap-table/pull/4218#issuecomment-475822706)
|
183 | - 2 spaces (no tabs)
|
184 | - "Attractive"
|
185 |
|
186 |
|
187 | ## License
|
188 |
|
189 | By contributing your code, you agree to license your contribution under the [MIT License](LICENSE).
|
190 | By contributing to the documentation, you agree to license your contribution under the [Creative Commons Attribution 3.0 Unported License](site/LICENSE).
|
191 |
|
192 |
|
193 | ## Financial contributions
|
194 |
|
195 | We also welcome financial contributions in full transparency on our [open collective](https://opencollective.com/bootstrap-table).
|
196 | Anyone can file an expense. If the expense makes sense for the development of the community, it will be "merged" in the ledger of our open collective by the core contributors and the person who filed the expense will be reimbursed.
|
197 |
|
198 |
|
199 | ## Credits
|
200 |
|
201 |
|
202 | ### Contributors
|
203 |
|
204 | Thank you to all the people who have already contributed to bootstrap-table!
|
205 | <a href="graphs/contributors"><img src="https://opencollective.com/bootstrap-table/contributors.svg?width=890" /></a>
|
206 |
|
207 |
|
208 | ### Backers
|
209 |
|
210 | Thank you to all our backers! [[Become a backer](https://opencollective.com/bootstrap-table#backer)]
|
211 |
|
212 | <a href="https://opencollective.com/bootstrap-table#backers" target="_blank"><img src="https://opencollective.com/bootstrap-table/backers.svg?width=890"></a>
|
213 |
|
214 |
|
215 | ### Sponsors
|
216 |
|
217 | Thank you to all our sponsors! (please ask your company to also support this open source project by [becoming a sponsor](https://opencollective.com/bootstrap-table#sponsor))
|
218 |
|
219 | <a href="https://opencollective.com/bootstrap-table/sponsor/0/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/0/avatar.svg"></a>
|
220 | <a href="https://opencollective.com/bootstrap-table/sponsor/1/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/1/avatar.svg"></a>
|
221 | <a href="https://opencollective.com/bootstrap-table/sponsor/2/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/2/avatar.svg"></a>
|
222 | <a href="https://opencollective.com/bootstrap-table/sponsor/3/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/3/avatar.svg"></a>
|
223 | <a href="https://opencollective.com/bootstrap-table/sponsor/4/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/4/avatar.svg"></a>
|
224 | <a href="https://opencollective.com/bootstrap-table/sponsor/5/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/5/avatar.svg"></a>
|
225 | <a href="https://opencollective.com/bootstrap-table/sponsor/6/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/6/avatar.svg"></a>
|
226 | <a href="https://opencollective.com/bootstrap-table/sponsor/7/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/7/avatar.svg"></a>
|
227 | <a href="https://opencollective.com/bootstrap-table/sponsor/8/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/8/avatar.svg"></a>
|
228 | <a href="https://opencollective.com/bootstrap-table/sponsor/9/website" target="_blank"><img src="https://opencollective.com/bootstrap-table/sponsor/9/avatar.svg"></a>
|
229 |
|
\ | No newline at end of file |