1 |
|
2 |
|
3 |
|
4 |
|
5 | "use strict";
|
6 |
|
7 |
|
8 |
|
9 |
|
10 |
|
11 | const SENTINEL_TYPE = /^(?:[a-zA-Z]+?Statement|ArrowFunctionExpression|FunctionExpression|ClassExpression)$/;
|
12 |
|
13 |
|
14 |
|
15 |
|
16 |
|
17 |
|
18 |
|
19 | function isEnclosedInParens(node, sourceCode) {
|
20 | const prevToken = sourceCode.getTokenBefore(node);
|
21 | const nextToken = sourceCode.getTokenAfter(node);
|
22 |
|
23 | return prevToken && prevToken.value === "(" && nextToken && nextToken.value === ")";
|
24 | }
|
25 |
|
26 |
|
27 |
|
28 |
|
29 |
|
30 | module.exports = {
|
31 | meta: {
|
32 | docs: {
|
33 | description: "disallow assignment operators in `return` statements",
|
34 | category: "Best Practices",
|
35 | recommended: false
|
36 | },
|
37 |
|
38 | schema: [
|
39 | {
|
40 | enum: ["except-parens", "always"]
|
41 | }
|
42 | ]
|
43 | },
|
44 |
|
45 | create(context) {
|
46 | const always = (context.options[0] || "except-parens") !== "except-parens";
|
47 | const sourceCode = context.getSourceCode();
|
48 |
|
49 | return {
|
50 | AssignmentExpression(node) {
|
51 | if (!always && isEnclosedInParens(node, sourceCode)) {
|
52 | return;
|
53 | }
|
54 |
|
55 | let parent = node.parent;
|
56 |
|
57 |
|
58 | while (parent && !SENTINEL_TYPE.test(parent.type)) {
|
59 | node = parent;
|
60 | parent = parent.parent;
|
61 | }
|
62 |
|
63 |
|
64 | if (parent && parent.type === "ReturnStatement") {
|
65 | context.report({
|
66 | node: parent,
|
67 | message: "Return statement should not contain assignment."
|
68 | });
|
69 | } else if (parent && parent.type === "ArrowFunctionExpression" && parent.body === node) {
|
70 | context.report({
|
71 | node: parent,
|
72 | message: "Arrow function should not return assignment."
|
73 | });
|
74 | }
|
75 | }
|
76 | };
|
77 | }
|
78 | };
|