UNPKG

8.97 kBJavaScriptView Raw
1/**
2 * @fileoverview Look for useless escapes in strings and regexes
3 * @author Onur Temizkan
4 */
5
6"use strict";
7
8const astUtils = require("../ast-utils");
9
10//------------------------------------------------------------------------------
11// Rule Definition
12//------------------------------------------------------------------------------
13
14/**
15 * Returns the union of two sets.
16 * @param {Set} setA The first set
17 * @param {Set} setB The second set
18 * @returns {Set} The union of the two sets
19 */
20function union(setA, setB) {
21 return new Set(function *() {
22 yield* setA;
23 yield* setB;
24 }());
25}
26
27const VALID_STRING_ESCAPES = union(new Set("\\nrvtbfux"), astUtils.LINEBREAKS);
28const REGEX_GENERAL_ESCAPES = new Set("\\bcdDfnrsStvwWxu0123456789]");
29const REGEX_NON_CHARCLASS_ESCAPES = union(REGEX_GENERAL_ESCAPES, new Set("^/.$*+?[{}|()B"));
30
31/**
32 * Parses a regular expression into a list of characters with character class info.
33 * @param {string} regExpText The raw text used to create the regular expression
34 * @returns {Object[]} A list of characters, each with info on escaping and whether they're in a character class.
35 * @example
36 *
37 * parseRegExp('a\\b[cd-]')
38 *
39 * returns:
40 * [
41 * {text: 'a', index: 0, escaped: false, inCharClass: false, startsCharClass: false, endsCharClass: false},
42 * {text: 'b', index: 2, escaped: true, inCharClass: false, startsCharClass: false, endsCharClass: false},
43 * {text: 'c', index: 4, escaped: false, inCharClass: true, startsCharClass: true, endsCharClass: false},
44 * {text: 'd', index: 5, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false},
45 * {text: '-', index: 6, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false}
46 * ]
47 */
48function parseRegExp(regExpText) {
49 const charList = [];
50
51 regExpText.split("").reduce((state, char, index) => {
52 if (!state.escapeNextChar) {
53 if (char === "\\") {
54 return Object.assign(state, { escapeNextChar: true });
55 }
56 if (char === "[" && !state.inCharClass) {
57 return Object.assign(state, { inCharClass: true, startingCharClass: true });
58 }
59 if (char === "]" && state.inCharClass) {
60 if (charList.length && charList[charList.length - 1].inCharClass) {
61 charList[charList.length - 1].endsCharClass = true;
62 }
63 return Object.assign(state, { inCharClass: false, startingCharClass: false });
64 }
65 }
66 charList.push({
67 text: char,
68 index,
69 escaped: state.escapeNextChar,
70 inCharClass: state.inCharClass,
71 startsCharClass: state.startingCharClass,
72 endsCharClass: false
73 });
74 return Object.assign(state, { escapeNextChar: false, startingCharClass: false });
75 }, { escapeNextChar: false, inCharClass: false, startingCharClass: false });
76
77 return charList;
78}
79
80module.exports = {
81 meta: {
82 docs: {
83 description: "disallow unnecessary escape characters",
84 category: "Best Practices",
85 recommended: true,
86 url: "https://eslint.org/docs/rules/no-useless-escape"
87 },
88
89 schema: []
90 },
91
92 create(context) {
93 const sourceCode = context.getSourceCode();
94
95 /**
96 * Reports a node
97 * @param {ASTNode} node The node to report
98 * @param {number} startOffset The backslash's offset from the start of the node
99 * @param {string} character The uselessly escaped character (not including the backslash)
100 * @returns {void}
101 */
102 function report(node, startOffset, character) {
103 context.report({
104 node,
105 loc: sourceCode.getLocFromIndex(sourceCode.getIndexFromLoc(node.loc.start) + startOffset),
106 message: "Unnecessary escape character: \\{{character}}.",
107 data: { character }
108 });
109 }
110
111 /**
112 * Checks if the escape character in given string slice is unnecessary.
113 *
114 * @private
115 * @param {ASTNode} node - node to validate.
116 * @param {string} match - string slice to validate.
117 * @returns {void}
118 */
119 function validateString(node, match) {
120 const isTemplateElement = node.type === "TemplateElement";
121 const escapedChar = match[0][1];
122 let isUnnecessaryEscape = !VALID_STRING_ESCAPES.has(escapedChar);
123 let isQuoteEscape;
124
125 if (isTemplateElement) {
126 isQuoteEscape = escapedChar === "`";
127
128 if (escapedChar === "$") {
129
130 // Warn if `\$` is not followed by `{`
131 isUnnecessaryEscape = match.input[match.index + 2] !== "{";
132 } else if (escapedChar === "{") {
133
134 /*
135 * Warn if `\{` is not preceded by `$`. If preceded by `$`, escaping
136 * is necessary and the rule should not warn. If preceded by `/$`, the rule
137 * will warn for the `/$` instead, as it is the first unnecessarily escaped character.
138 */
139 isUnnecessaryEscape = match.input[match.index - 1] !== "$";
140 }
141 } else {
142 isQuoteEscape = escapedChar === node.raw[0];
143 }
144
145 if (isUnnecessaryEscape && !isQuoteEscape) {
146 report(node, match.index + 1, match[0].slice(1));
147 }
148 }
149
150 /**
151 * Checks if a node has an escape.
152 *
153 * @param {ASTNode} node - node to check.
154 * @returns {void}
155 */
156 function check(node) {
157 const isTemplateElement = node.type === "TemplateElement";
158
159 if (
160 isTemplateElement &&
161 node.parent &&
162 node.parent.parent &&
163 node.parent.parent.type === "TaggedTemplateExpression" &&
164 node.parent === node.parent.parent.quasi
165 ) {
166
167 // Don't report tagged template literals, because the backslash character is accessible to the tag function.
168 return;
169 }
170
171 if (typeof node.value === "string" || isTemplateElement) {
172
173 /*
174 * JSXAttribute doesn't have any escape sequence: https://facebook.github.io/jsx/.
175 * In addition, backticks are not supported by JSX yet: https://github.com/facebook/jsx/issues/25.
176 */
177 if (node.parent.type === "JSXAttribute" || node.parent.type === "JSXElement") {
178 return;
179 }
180
181 const value = isTemplateElement ? node.value.raw : node.raw.slice(1, -1);
182 const pattern = /\\[^\d]/g;
183 let match;
184
185 while ((match = pattern.exec(value))) {
186 validateString(node, match);
187 }
188 } else if (node.regex) {
189 parseRegExp(node.regex.pattern)
190
191 /*
192 * The '-' character is a special case, because it's only valid to escape it if it's in a character
193 * class, and is not at either edge of the character class. To account for this, don't consider '-'
194 * characters to be valid in general, and filter out '-' characters that appear in the middle of a
195 * character class.
196 */
197 .filter(charInfo => !(charInfo.text === "-" && charInfo.inCharClass && !charInfo.startsCharClass && !charInfo.endsCharClass))
198
199 /*
200 * The '^' character is also a special case; it must always be escaped outside of character classes, but
201 * it only needs to be escaped in character classes if it's at the beginning of the character class. To
202 * account for this, consider it to be a valid escape character outside of character classes, and filter
203 * out '^' characters that appear at the start of a character class.
204 */
205 .filter(charInfo => !(charInfo.text === "^" && charInfo.startsCharClass))
206
207 // Filter out characters that aren't escaped.
208 .filter(charInfo => charInfo.escaped)
209
210 // Filter out characters that are valid to escape, based on their position in the regular expression.
211 .filter(charInfo => !(charInfo.inCharClass ? REGEX_GENERAL_ESCAPES : REGEX_NON_CHARCLASS_ESCAPES).has(charInfo.text))
212
213 // Report all the remaining characters.
214 .forEach(charInfo => report(node, charInfo.index, charInfo.text));
215 }
216
217 }
218
219 return {
220 Literal: check,
221 TemplateElement: check
222 };
223 }
224};