UNPKG

9.19 kBJavaScriptView Raw
1/**
2 * @fileoverview Look for useless escapes in strings and regexes
3 * @author Onur Temizkan
4 */
5
6"use strict";
7
8const astUtils = require("./utils/ast-utils");
9
10//------------------------------------------------------------------------------
11// Rule Definition
12//------------------------------------------------------------------------------
13
14/**
15 * Returns the union of two sets.
16 * @param {Set} setA The first set
17 * @param {Set} setB The second set
18 * @returns {Set} The union of the two sets
19 */
20function union(setA, setB) {
21 return new Set(function *() {
22 yield* setA;
23 yield* setB;
24 }());
25}
26
27const VALID_STRING_ESCAPES = union(new Set("\\nrvtbfux"), astUtils.LINEBREAKS);
28const REGEX_GENERAL_ESCAPES = new Set("\\bcdDfnpPrsStvwWxu0123456789]");
29const REGEX_NON_CHARCLASS_ESCAPES = union(REGEX_GENERAL_ESCAPES, new Set("^/.$*+?[{}|()Bk"));
30
31/**
32 * Parses a regular expression into a list of characters with character class info.
33 * @param {string} regExpText The raw text used to create the regular expression
34 * @returns {Object[]} A list of characters, each with info on escaping and whether they're in a character class.
35 * @example
36 *
37 * parseRegExp('a\\b[cd-]')
38 *
39 * returns:
40 * [
41 * {text: 'a', index: 0, escaped: false, inCharClass: false, startsCharClass: false, endsCharClass: false},
42 * {text: 'b', index: 2, escaped: true, inCharClass: false, startsCharClass: false, endsCharClass: false},
43 * {text: 'c', index: 4, escaped: false, inCharClass: true, startsCharClass: true, endsCharClass: false},
44 * {text: 'd', index: 5, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false},
45 * {text: '-', index: 6, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false}
46 * ]
47 */
48function parseRegExp(regExpText) {
49 const charList = [];
50
51 regExpText.split("").reduce((state, char, index) => {
52 if (!state.escapeNextChar) {
53 if (char === "\\") {
54 return Object.assign(state, { escapeNextChar: true });
55 }
56 if (char === "[" && !state.inCharClass) {
57 return Object.assign(state, { inCharClass: true, startingCharClass: true });
58 }
59 if (char === "]" && state.inCharClass) {
60 if (charList.length && charList[charList.length - 1].inCharClass) {
61 charList[charList.length - 1].endsCharClass = true;
62 }
63 return Object.assign(state, { inCharClass: false, startingCharClass: false });
64 }
65 }
66 charList.push({
67 text: char,
68 index,
69 escaped: state.escapeNextChar,
70 inCharClass: state.inCharClass,
71 startsCharClass: state.startingCharClass,
72 endsCharClass: false
73 });
74 return Object.assign(state, { escapeNextChar: false, startingCharClass: false });
75 }, { escapeNextChar: false, inCharClass: false, startingCharClass: false });
76
77 return charList;
78}
79
80module.exports = {
81 meta: {
82 type: "suggestion",
83
84 docs: {
85 description: "disallow unnecessary escape characters",
86 category: "Best Practices",
87 recommended: true,
88 url: "https://eslint.org/docs/rules/no-useless-escape"
89 },
90
91 schema: []
92 },
93
94 create(context) {
95 const sourceCode = context.getSourceCode();
96
97 /**
98 * Reports a node
99 * @param {ASTNode} node The node to report
100 * @param {number} startOffset The backslash's offset from the start of the node
101 * @param {string} character The uselessly escaped character (not including the backslash)
102 * @returns {void}
103 */
104 function report(node, startOffset, character) {
105 const start = sourceCode.getLocFromIndex(sourceCode.getIndexFromLoc(node.loc.start) + startOffset);
106
107 context.report({
108 node,
109 loc: {
110 start,
111 end: { line: start.line, column: start.column + 1 }
112 },
113 message: "Unnecessary escape character: \\{{character}}.",
114 data: { character }
115 });
116 }
117
118 /**
119 * Checks if the escape character in given string slice is unnecessary.
120 *
121 * @private
122 * @param {ASTNode} node - node to validate.
123 * @param {string} match - string slice to validate.
124 * @returns {void}
125 */
126 function validateString(node, match) {
127 const isTemplateElement = node.type === "TemplateElement";
128 const escapedChar = match[0][1];
129 let isUnnecessaryEscape = !VALID_STRING_ESCAPES.has(escapedChar);
130 let isQuoteEscape;
131
132 if (isTemplateElement) {
133 isQuoteEscape = escapedChar === "`";
134
135 if (escapedChar === "$") {
136
137 // Warn if `\$` is not followed by `{`
138 isUnnecessaryEscape = match.input[match.index + 2] !== "{";
139 } else if (escapedChar === "{") {
140
141 /*
142 * Warn if `\{` is not preceded by `$`. If preceded by `$`, escaping
143 * is necessary and the rule should not warn. If preceded by `/$`, the rule
144 * will warn for the `/$` instead, as it is the first unnecessarily escaped character.
145 */
146 isUnnecessaryEscape = match.input[match.index - 1] !== "$";
147 }
148 } else {
149 isQuoteEscape = escapedChar === node.raw[0];
150 }
151
152 if (isUnnecessaryEscape && !isQuoteEscape) {
153 report(node, match.index + 1, match[0].slice(1));
154 }
155 }
156
157 /**
158 * Checks if a node has an escape.
159 *
160 * @param {ASTNode} node - node to check.
161 * @returns {void}
162 */
163 function check(node) {
164 const isTemplateElement = node.type === "TemplateElement";
165
166 if (
167 isTemplateElement &&
168 node.parent &&
169 node.parent.parent &&
170 node.parent.parent.type === "TaggedTemplateExpression" &&
171 node.parent === node.parent.parent.quasi
172 ) {
173
174 // Don't report tagged template literals, because the backslash character is accessible to the tag function.
175 return;
176 }
177
178 if (typeof node.value === "string" || isTemplateElement) {
179
180 /*
181 * JSXAttribute doesn't have any escape sequence: https://facebook.github.io/jsx/.
182 * In addition, backticks are not supported by JSX yet: https://github.com/facebook/jsx/issues/25.
183 */
184 if (node.parent.type === "JSXAttribute" || node.parent.type === "JSXElement" || node.parent.type === "JSXFragment") {
185 return;
186 }
187
188 const value = isTemplateElement ? node.value.raw : node.raw.slice(1, -1);
189 const pattern = /\\[^\d]/gu;
190 let match;
191
192 while ((match = pattern.exec(value))) {
193 validateString(node, match);
194 }
195 } else if (node.regex) {
196 parseRegExp(node.regex.pattern)
197
198 /*
199 * The '-' character is a special case, because it's only valid to escape it if it's in a character
200 * class, and is not at either edge of the character class. To account for this, don't consider '-'
201 * characters to be valid in general, and filter out '-' characters that appear in the middle of a
202 * character class.
203 */
204 .filter(charInfo => !(charInfo.text === "-" && charInfo.inCharClass && !charInfo.startsCharClass && !charInfo.endsCharClass))
205
206 /*
207 * The '^' character is also a special case; it must always be escaped outside of character classes, but
208 * it only needs to be escaped in character classes if it's at the beginning of the character class. To
209 * account for this, consider it to be a valid escape character outside of character classes, and filter
210 * out '^' characters that appear at the start of a character class.
211 */
212 .filter(charInfo => !(charInfo.text === "^" && charInfo.startsCharClass))
213
214 // Filter out characters that aren't escaped.
215 .filter(charInfo => charInfo.escaped)
216
217 // Filter out characters that are valid to escape, based on their position in the regular expression.
218 .filter(charInfo => !(charInfo.inCharClass ? REGEX_GENERAL_ESCAPES : REGEX_NON_CHARCLASS_ESCAPES).has(charInfo.text))
219
220 // Report all the remaining characters.
221 .forEach(charInfo => report(node, charInfo.index, charInfo.text));
222 }
223
224 }
225
226 return {
227 Literal: check,
228 TemplateElement: check
229 };
230 }
231};