UNPKG

1.83 kBMarkdownView Raw
1Contributing to horse
2==========================
3
4So you want to contribute to horse? Fantastic! Here's a brief overview on
5how best to do so.
6
7## What to change
8
9Here's some examples of things you might want to make a pull request for:
10
11* New features
12* Bugfixes
13* Inefficient blocks of code
14
15If you have a more deeply-rooted problem with how the program is built or some
16of the stylistic decisions made in the code, it's best to
17[create an issue](https://github.com/reddit/horse/issues) before putting
18the effort into a pull request. The same goes for new features - it is
19best to check the project's direction, existing pull requests, and currently open
20and closed issues first.
21
22## Style
23
24* Two spaces, not tabs
25* Semicolons are not optional
26* All pages should render on the server and the client. The site should be
27 usable without javascript.
28* Review our [style guide](https://github.com/reddit/tree/master/javascript) for
29 more information.
30
31Look at existing code to get a good feel for the patterns we use. Please run
32tests before submitting any pull requests. Instructions for running tests can
33be found in the README.
34
35## Using Git appropriately
36
371. [Fork the repository](https://github.com/reddit/horse/fork_select) to
38 your Github account.
392. Create a *topical branch* - a branch whose name is succint but explains what
40 you're doing, such as "change-orangered-to-periwinkle"
413. Make your changes, committing at logical breaks.
424. Push your branch to your personal account
435. [Create a pull request](https://help.github.com/articles/using-pull-requests)
446. Watch for comments or acceptance
45
46Please make separate branches for unrelated changes!
47
48## Licensing
49
50horse is MIT licensed. See details in the LICENSE file. This is a very permissive
51scheme, GPL-compatible but without many of the restrictions of GPL.