UNPKG

23.8 kBMarkdownView Raw
1# 🚫💩 lint-staged ![GitHub Actions](https://github.com/okonet/lint-staged/workflows/CI/badge.svg) [![Build Status for Windows](https://ci.appveyor.com/api/projects/status/github/okonet/lint-staged?branch=master&svg=true)](https://ci.appveyor.com/project/okonet/lint-staged) [![npm version](https://badge.fury.io/js/lint-staged.svg)](https://badge.fury.io/js/lint-staged) [![Codecov](https://codecov.io/gh/okonet/lint-staged/branch/master/graph/badge.svg)](https://codecov.io/gh/okonet/lint-staged)
2
3Run linters against staged git files and don't let :poop: slip into your code base!
4
5[![asciicast](https://asciinema.org/a/199934.svg)](https://asciinema.org/a/199934)
6
7## Why
8
9Linting makes more sense when run before committing your code. By doing so you can ensure no errors go into the repository and enforce code style. But running a lint process on a whole project is slow and linting results can be irrelevant. Ultimately you only want to lint files that will be committed.
10
11This project contains a script that will run arbitrary shell tasks with a list of staged files as an argument, filtered by a specified glob pattern.
12
13## Related blogs posts and talks
14
15- [Make Linting Great Again](https://medium.com/@okonetchnikov/make-linting-great-again-f3890e1ad6b8#.8qepn2b5l)
16- [Running Jest Tests Before Each Git Commit](https://benmccormick.org/2017/02/26/running-jest-tests-before-each-git-commit/)
17- [AgentConf: Make Linting Great Again](https://www.youtube.com/watch?v=-mhY7e-EsC4)
18- [SurviveJS Interview](https://survivejs.com/blog/lint-staged-interview/)
19
20> If you've written one, please submit a PR with the link to it!
21
22## Installation and setup
23
24The fastest way to start using lint-staged is to run following command in your terminal:
25
26```bash
27npx mrm lint-staged
28```
29
30It will install and configure [husky](https://github.com/typicode/husky) and lint-staged depending on code quality tools from `package.json` dependencies so please make sure you install (`npm install --save-dev`) and configure all code quality tools like [Prettier](https://prettier.io), [ESlint](https://eslint.org) prior that.
31
32Don't forget to commit changes to `package.json` to share this setup with your team!
33
34Now change a few files, `git add` or `git add --patch` some of them to your commit and try to `git commit` them.
35
36See [examples](#examples) and [configuration](#configuration) for more information.
37
38## Changelog
39
40See [Releases](https://github.com/okonet/lint-staged/releases)
41
42### Migration
43
44#### v10
45
46- From `v10.0.0` onwards any new modifications to originally staged files will be automatically added to the commit.
47 If your task previously contained a `git add` step, please remove this.
48 The automatic behaviour ensures there are less race-conditions,
49 since trying to run multiple git operations at the same time usually results in an error.
50- From `v10.0.0` onwards _lint-staged_ uses git stashes to improve speed and provide backups while running.
51 Since git stashes require at least an initial commit, you shouldn't run _lint-staged_ in an empty repo.
52- From `v10.0.0` onwards _lint-staged_ requires Node.js version 10.13.0 or later.
53- From `v10.0.0` onwards _lint-staged_ will abort the commit if linter tasks undo all staged changes. To allow creating empty commit, please use the `--allow-empty` option.
54
55## Command line flags
56
57```bash
58❯ npx lint-staged --help
59Usage: lint-staged [options]
60
61Options:
62 -V, --version output the version number
63 --allow-empty allow empty commits when tasks revert all staged changes
64 (default: false)
65 -c, --config [path] path to configuration file, or - to read from stdin
66 -d, --debug print additional debug information (default: false)
67 --no-stash disable the backup stash, and do not revert in case of
68 errors
69 -p, --concurrent <parallel tasks> the number of tasks to run concurrently, or false to run
70 tasks serially (default: true)
71 -q, --quiet disable lint-staged’s own console output (default: false)
72 -r, --relative pass relative filepaths to tasks (default: false)
73 -x, --shell skip parsing of tasks for better shell support (default:
74 false)
75 -v, --verbose show task output even when tasks succeed; by default only
76 failed output is shown (default: false)
77 -h, --help display help for command
78```
79
80- **`--allow-empty`**: By default, when linter tasks undo all staged changes, lint-staged will exit with an error and abort the commit. Use this flag to allow creating empty git commits.
81- **`--config [path]`**: Manually specify a path to a config file or npm package name. Note: when used, lint-staged won't perform the config file search and print an error if the specified file cannot be found. If '-' is provided as the filename then the config will be read from stdin, allowing piping in the config like `cat my-config.json | npx lint-staged --config -`.
82- **`--debug`**: Run in debug mode. When set, it does the following:
83 - uses [debug](https://github.com/visionmedia/debug) internally to log additional information about staged files, commands being executed, location of binaries, etc. Debug logs, which are automatically enabled by passing the flag, can also be enabled by setting the environment variable `$DEBUG` to `lint-staged*`.
84 - uses [`verbose` renderer](https://github.com/SamVerschueren/listr-verbose-renderer) for `listr`; this causes serial, uncoloured output to the terminal, instead of the default (beautified, dynamic) output.
85- **`--concurrent [number | (true/false)]`**: Controls the concurrency of tasks being run by lint-staged. **NOTE**: This does NOT affect the concurrency of subtasks (they will always be run sequentially). Possible values are:
86 - `false`: Run all tasks serially
87 - `true` (default) : _Infinite_ concurrency. Runs as many tasks in parallel as possible.
88 - `{number}`: Run the specified number of tasks in parallel, where `1` is equivalent to `false`.
89- **`--no-stash`**: By default a backup stash will be created before running the tasks, and all task modifications will be reverted in case of an error. This option will disable creating the stash, and instead leave all modifications in the index when aborting the commit.
90- **`--quiet`**: Supress all CLI output, except from tasks.
91- **`--relative`**: Pass filepaths relative to `process.cwd()` (where `lint-staged` runs) to tasks. Default is `false`.
92- **`--shell`**: By default linter commands will be parsed for speed and security. This has the side-effect that regular shell scripts might not work as expected. You can skip parsing of commands with this option.
93- **`--verbose`**: Show task output even when tasks succeed. By default only failed output is shown.
94
95## Configuration
96
97Starting with v3.1 you can now use different ways of configuring it:
98
99- `lint-staged` object in your `package.json`
100- `.lintstagedrc` file in JSON or YML format, or you can be explicit with the file extension:
101 - `.lintstagedrc.json`
102 - `.lintstagedrc.yaml`
103 - `.lintstagedrc.yml`
104- `lint-staged.config.js`, `.lintstagedrc.js`, or `.lintstagedrc.cjs` file in JS format
105- Pass a configuration file using the `--config` or `-c` flag
106
107See [cosmiconfig](https://github.com/davidtheclark/cosmiconfig) for more details on what formats are supported.
108
109Configuration should be an object where each value is a command to run and its key is a glob pattern to use for this command. This package uses [micromatch](https://github.com/micromatch/micromatch) for glob patterns.
110
111#### `package.json` example:
112
113```json
114{
115 "lint-staged": {
116 "*": "your-cmd"
117 }
118}
119```
120
121#### `.lintstagedrc` example
122
123```json
124{
125 "*": "your-cmd"
126}
127```
128
129This config will execute `your-cmd` with the list of currently staged files passed as arguments.
130
131So, considering you did `git add file1.ext file2.ext`, lint-staged will run the following command:
132
133`your-cmd file1.ext file2.ext`
134
135## Filtering files
136
137Linter commands work on a subset of all staged files, defined by a _glob pattern_. `lint-staged´ uses [micromatch](https://github.com/micromatch/micromatch) for matching files with the following rules:
138
139- If the glob pattern contains no slashes (`/`), micromatch's `matchBase` option will enabled, so globs match a file's basename regardless of directory:
140 - **`"*.js"`** will match all JS files, like `/test.js` and `/foo/bar/test.js`
141 - **`"!(*test).js"`**. will match all JS files, except those ending in `test.js`, so `foo.js` but not `foo.test.js`
142- If the glob pattern does contain a slash (`/`), it will match for paths as well:
143 - **`"./*.js"`** will match all JS files in the git repo root, so `/test.js` but not `/foo/bar/test.js`
144 - **`"foo/**/\*.js"`** will match all JS files inside the`/foo`directory, so`/foo/bar/test.js`but not`/test.js`
145
146When matching, `lint-staged` will do the following
147
148- Resolve the git root automatically, no configuration needed.
149- Pick the staged files which are present inside the project directory.
150- Filter them using the specified glob patterns.
151- Pass absolute paths to the linters as arguments.
152
153**NOTE:** `lint-staged` will pass _absolute_ paths to the linters to avoid any confusion in case they're executed in a different working directory (i.e. when your `.git` directory isn't the same as your `package.json` directory).
154
155Also see [How to use `lint-staged` in a multi package monorepo?](#how-to-use-lint-staged-in-a-multi-package-monorepo)
156
157### Ignoring files
158
159The concept of `lint-staged` is to run configured linter (or other) tasks on files that are staged in git. `lint-staged` will always pass a list of all staged files to the task, and ignoring any files should be configured in the task itself.
160
161Consider a project that uses [`prettier`](https://prettier.io/) to keep code format consistent across all files. The project also stores minified 3rd-party vendor libraries in the `vendor/` directory. To keep `prettier` from throwing errors on these files, the vendor directory should be added to prettier's ignore configuration, the `.prettierignore` file. Running `npx prettier .` will ignore the entire vendor directory, throwing no errors. When `lint-staged` is added to the project and configured to run prettier, all modified and staged files in the vendor directory will be ignored by prettier, even though it receives them as input.
162
163In advanced scenarios, where it is impossible to configure the linter task itself to ignore files, but some staged files should still be ignored by `lint-staged`, it is possible to filter filepaths before passing them to tasks by using the function syntax. See [Example: Ignore files from match](#example-ignore-files-from-match).
164
165## What commands are supported?
166
167Supported are any executables installed locally or globally via `npm` as well as any executable from your \$PATH.
168
169> Using globally installed scripts is discouraged, since lint-staged may not work for someone who doesn’t have it installed.
170
171`lint-staged` uses [execa](https://github.com/sindresorhus/execa#preferlocal) to locate locally installed scripts. So in your `.lintstagedrc` you can write:
172
173```json
174{
175 "*.js": "eslint --fix"
176}
177```
178
179Pass arguments to your commands separated by space as you would do in the shell. See [examples](#examples) below.
180
181## Running multiple commands in a sequence
182
183You can run multiple commands in a sequence on every glob. To do so, pass an array of commands instead of a single one. This is useful for running autoformatting tools like `eslint --fix` or `stylefmt` but can be used for any arbitrary sequences.
184
185For example:
186
187```json
188{
189 "*.js": ["eslint", "prettier --write"]
190}
191```
192
193going to execute `eslint` and if it exits with `0` code, it will execute `prettier --write` on all staged `*.js` files.
194
195## Using JS configuration file
196
197Writing the configuration file in JavaScript is the most powerful way to configure _lint-staged_ (`lint-staged.config.js`, [similar](https://github.com/okonet/lint-staged/README.md#configuration), or passed via `--config`). From the configuration file, you can export either a single function, or an object.
198
199If the `exports` value is a function, it will receive an array of all staged filenames. You can then build your own matchers for the files, and return a command string, or an array or command strings. These strings are considered complete and should include the filename arguments, if wanted.
200
201If the `exports` value is an object, its keys should be glob matches (like in the normal non-js config format). The values can either be like in the normal config, or individual functions like described above. Instead of receiving all matched files, the functions in the exported object will only receive the staged files matching the corresponding glob key.
202
203### Function signature
204
205The function can also be async:
206
207```ts
208(filenames: string[]) => string | string[] | Promise<string | string[]>
209```
210
211### Example: Export a function to build your own matchers
212
213```js
214// lint-staged.config.js
215const micromatch = require('micromatch')
216
217module.exports = (allStagedFiles) => {
218 const shFiles = micromatch(allStagedFiles, ['**/src/**/*.sh']);
219 if (shFiles.length) {
220 return `printf '%s\n' "Script files aren't allowed in src directory" >&2`
221 }
222 const codeFiles = micromatch(allStagedFiles, ['**/*.js', '**/*.ts']);
223 const docFiles = micromatch(allStagedFiles, ['**/*.md']);
224 return [`eslint ${codeFiles.join(' ')}`, `mdl ${docFiles.join(' ')}`];
225 }
226```
227
228
229### Example: Wrap filenames in single quotes and run once per file
230
231```js
232// .lintstagedrc.js
233module.exports = {
234 '**/*.js?(x)': (filenames) => filenames.map((filename) => `prettier --write '${filename}'`)
235}
236```
237
238### Example: Run `tsc` on changes to TypeScript files, but do not pass any filename arguments
239
240```js
241// lint-staged.config.js
242module.exports = {
243 '**/*.ts?(x)': () => 'tsc -p tsconfig.json --noEmit'
244}
245```
246
247### Example: Run eslint on entire repo if more than 10 staged files
248
249```js
250// .lintstagedrc.js
251module.exports = {
252 '**/*.js?(x)': (filenames) =>
253 filenames.length > 10 ? 'eslint .' : `eslint ${filenames.join(' ')}`
254}
255```
256
257### Example: Use your own globs
258It's better to use the [function-based configuration (seen above)](https://github.com/okonet/lint-staged/README.md#example-export-a-function-to-build-your-own-matchers), if your use case is this.
259
260```js
261// lint-staged.config.js
262const micromatch = require('micromatch')
263
264module.exports = {
265 '*': (allFiles) => {
266 const codeFiles = micromatch(allFiles, ['**/*.js', '**/*.ts']);
267 const docFiles = micromatch(allFiles, ['**/*.md']);
268 return [`eslint ${codeFiles.join(' ')}`, `mdl ${docFiles.join(' ')}`];
269 }
270}
271```
272
273### Example: Ignore files from match
274
275If for some reason you want to ignore files from the glob match, you can use `micromatch.not()`:
276
277```js
278// lint-staged.config.js
279const micromatch = require('micromatch')
280
281module.exports = {
282 '*.js': (files) => {
283 // from `files` filter those _NOT_ matching `*test.js`
284 const match = micromatch.not(files, '*test.js')
285 return `eslint ${match.join(' ')}`
286 }
287}
288```
289
290Please note that for most cases, globs can achieve the same effect. For the above example, a matching glob would be `!(*test).js`.
291
292### Example: Use relative paths for commands
293
294```js
295const path = require('path')
296
297module.exports = {
298 '*.ts': (absolutePaths) => {
299 const cwd = process.cwd()
300 const relativePaths = absolutePaths.map((file) => path.relative(cwd, file))
301 return `ng lint myProjectName --files ${relativePaths.join(' ')}`
302 }
303}
304```
305
306## Reformatting the code
307
308Tools like [Prettier](https://prettier.io), ESLint/TSLint, or stylelint can reformat your code according to an appropriate config by running `prettier --write`/`eslint --fix`/`tslint --fix`/`stylelint --fix`. Lint-staged will automatically add any modifications to the commit as long as there are no errors.
309
310```json
311{
312 "*.js": "prettier --write"
313}
314```
315
316Prior to version 10, tasks had to manually include `git add` as the final step. This behavior has been integrated into lint-staged itself in order to prevent race conditions with multiple tasks editing the same files. If lint-staged detects `git add` in task configurations, it will show a warning in the console. Please remove `git add` from your configuration after upgrading.
317
318## Examples
319
320All examples assuming you’ve already set up lint-staged and husky in the `package.json`.
321
322```json
323{
324 "name": "My project",
325 "version": "0.1.0",
326 "scripts": {
327 "my-custom-script": "linter --arg1 --arg2"
328 },
329 "husky": {
330 "hooks": {
331 "pre-commit": "lint-staged"
332 }
333 },
334 "lint-staged": {}
335}
336```
337
338_Note we don’t pass a path as an argument for the runners. This is important since lint-staged will do this for you._
339
340### ESLint with default parameters for `*.js` and `*.jsx` running as a pre-commit hook
341
342```json
343{
344 "*.{js,jsx}": "eslint"
345}
346```
347
348### Automatically fix code style with `--fix` and add to commit
349
350```json
351{
352 "*.js": "eslint --fix"
353}
354```
355
356This will run `eslint --fix` and automatically add changes to the commit.
357
358### Reuse npm script
359
360If you wish to reuse a npm script defined in your package.json:
361
362```json
363{
364 "*.js": "npm run my-custom-script --"
365}
366```
367
368The following is equivalent:
369
370```json
371{
372 "*.js": "linter --arg1 --arg2"
373}
374```
375
376### Use environment variables with linting commands
377
378Linting commands _do not_ support the shell convention of expanding environment variables. To enable the convention yourself, use a tool like [`cross-env`](https://github.com/kentcdodds/cross-env).
379
380For example, here is `jest` running on all `.js` files with the `NODE_ENV` variable being set to `"test"`:
381
382```json
383{
384 "*.js": ["cross-env NODE_ENV=test jest --bail --findRelatedTests"]
385}
386```
387
388### Automatically fix code style with `prettier` for javascript, typescript, markdown, HTML, or CSS
389
390```json
391{
392 "*.{js,jsx,ts,tsx,md,html,css}": "prettier --write"
393}
394```
395
396### Stylelint for CSS with defaults and for SCSS with SCSS syntax
397
398```json
399{
400 "*.css": "stylelint",
401 "*.scss": "stylelint --syntax=scss"
402}
403```
404
405### Run PostCSS sorting and Stylelint to check
406
407```json
408{
409 "*.scss": ["postcss --config path/to/your/config --replace", "stylelint"]
410}
411```
412
413### Minify the images
414
415```json
416{
417 "*.{png,jpeg,jpg,gif,svg}": "imagemin-lint-staged"
418}
419```
420
421<details>
422 <summary>More about <code>imagemin-lint-staged</code></summary>
423
424[imagemin-lint-staged](https://github.com/tomchentw/imagemin-lint-staged) is a CLI tool designed for lint-staged usage with sensible defaults.
425
426See more on [this blog post](https://medium.com/@tomchentw/imagemin-lint-staged-in-place-minify-the-images-before-adding-to-the-git-repo-5acda0b4c57e) for benefits of this approach.
427
428</details>
429
430### Typecheck your staged files with flow
431
432```json
433{
434 "*.{js,jsx}": "flow focus-check"
435}
436```
437
438## Frequently Asked Questions
439
440### Can I use `lint-staged` via node?
441
442Yes!
443
444```js
445const lintStaged = require('lint-staged')
446
447try {
448 const success = await lintStaged()
449 console.log(success ? 'Linting was successful!' : 'Linting failed!')
450} catch (e) {
451 // Failed to load configuration
452 console.error(e)
453}
454```
455
456Parameters to `lintStaged` are equivalent to their CLI counterparts:
457
458```js
459const success = await lintStaged({
460 allowEmpty: false,
461 concurrent: true,
462 configPath: './path/to/configuration/file',
463 cwd: process.cwd(),
464 debug: false,
465 maxArgLength: null,
466 quiet: false,
467 relative: false,
468 shell: false
469 stash: true,
470 verbose: false
471})
472```
473
474You can also pass config directly with `config` option:
475
476```js
477const success = await lintStaged({
478 allowEmpty: false,
479 concurrent: true,
480 config: { '*.js': 'eslint --fix' },
481 cwd: process.cwd(),
482 debug: false,
483 maxArgLength: null,
484 quiet: false,
485 relative: false,
486 shell: false,
487 stash: true,
488 verbose: false
489})
490```
491
492The `maxArgLength` option configures chunking of tasks into multiple parts that are run one after the other. This is to avoid issues on Windows platforms where the maximum length of the command line argument string is limited to 8192 characters. Lint-staged might generate a very long argument string when there are many staged files. This option is set automatically from the cli, but not via the Node.js API by default.
493
494### Using with JetBrains IDEs _(WebStorm, PyCharm, IntelliJ IDEA, RubyMine, etc.)_
495
496_**Update**_: The latest version of JetBrains IDEs now support running hooks as you would expect.
497
498When using the IDE's GUI to commit changes with the `precommit` hook, you might see inconsistencies in the IDE and command line. This is [known issue](https://youtrack.jetbrains.com/issue/IDEA-135454) at JetBrains so if you want this fixed, please vote for it on YouTrack.
499
500Until the issue is resolved in the IDE, you can use the following config to work around it:
501
502husky v1.x
503
504```json
505{
506 "husky": {
507 "hooks": {
508 "pre-commit": "lint-staged",
509 "post-commit": "git update-index --again"
510 }
511 }
512}
513```
514
515husky v0.x
516
517```json
518{
519 "scripts": {
520 "precommit": "lint-staged",
521 "postcommit": "git update-index --again"
522 }
523}
524```
525
526_Thanks to [this comment](https://youtrack.jetbrains.com/issue/IDEA-135454#comment=27-2710654) for the fix!_
527
528### How to use `lint-staged` in a multi package monorepo?
529
530Starting with v5.0, `lint-staged` automatically resolves the git root **without any** additional configuration. You configure `lint-staged` as you normally would if your project root and git root were the same directory.
531
532If you wish to use `lint-staged` in a multi package monorepo, it is recommended to install [`husky`](https://github.com/typicode/husky) in the root package.json.
533[`lerna`](https://github.com/lerna/lerna) can be used to execute the `precommit` script in all sub-packages.
534
535Example repo: [sudo-suhas/lint-staged-multi-pkg](https://github.com/sudo-suhas/lint-staged-multi-pkg).
536
537### Can I lint files outside of the current project folder?
538
539tl;dr: Yes, but the pattern should start with `../`.
540
541By default, `lint-staged` executes linters only on the files present inside the project folder(where `lint-staged` is installed and run from).
542So this question is relevant _only_ when the project folder is a child folder inside the git repo.
543In certain project setups, it might be desirable to bypass this restriction. See [#425](https://github.com/okonet/lint-staged/issues/425), [#487](https://github.com/okonet/lint-staged/issues/487) for more context.
544
545`lint-staged` provides an escape hatch for the same(`>= v7.3.0`). For patterns that start with `../`, all the staged files are allowed to match against the pattern.
546Note that patterns like `*.js`, `**/*.js` will still only match the project files and not any of the files in parent or sibling directories.
547
548Example repo: [sudo-suhas/lint-staged-django-react-demo](https://github.com/sudo-suhas/lint-staged-django-react-demo).
549
550### How can i ignore files from `.eslintignore` ?
551
552ESLint throws out `warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override` warnings that breaks the linting process ( if you used `--max-warnings=0` which is recommended ).
553
554Based on the discussion from https://github.com/eslint/eslint/issues/9977 , it was decided that using [the outlined script ](https://github.com/eslint/eslint/issues/9977#issuecomment-406420893)is the best route to fix this.
555
556So you can setup a `.lintstagedrc.js` config file to do this:
557
558```js
559const { CLIEngine } = require('eslint')
560
561const cli = new CLIEngine({})
562
563module.exports = {
564 '*.js': (files) =>
565 'eslint --max-warnings=0 ' + files.filter((file) => !cli.isPathIgnored(file)).join(' ')
566}
567```