1 | # Contributing to Miscord
|
2 |
|
3 | :+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
|
4 |
|
5 | The following is a set of guidelines for contributing to Miscord and its packages, which are hosted in the [Miscord Organization](https://github.com/miscord) on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request.
|
6 |
|
7 | #### Table Of Contents
|
8 |
|
9 | [Code of Conduct](CODE_OF_CONDUCT.md)
|
10 |
|
11 | [I don't want to read this whole thing, I just have a question!!!](#i-dont-want-to-read-this-whole-thing-i-just-have-a-question)
|
12 |
|
13 | [How Can I Contribute?](#how-can-i-contribute)
|
14 | * [Reporting Bugs](#reporting-bugs)
|
15 | * [Suggesting Enhancements](#suggesting-enhancements)
|
16 | * [Your First Code Contribution](#your-first-code-contribution)
|
17 | * [Pull Requests](#pull-requests)
|
18 |
|
19 | [Styleguides](#styleguides)
|
20 | * [Git Commit Messages](#git-commit-messages)
|
21 | * [JavaScript Styleguide](#javascript-styleguide)
|
22 |
|
23 | ## I don't want to read this whole thing I just have a question!!!
|
24 |
|
25 | > **Note:** You'll get faster results by using the resources below.
|
26 |
|
27 | We have an official Discord server where the community chimes in with helpful advice if you have questions.
|
28 |
|
29 | [![Discord](https://discordapp.com/api/guilds/431471556540104724/embed.png)](https://discord.gg/DkmTvVz)
|
30 |
|
31 | Also, take a look at our FAQ (`#faq` on Discord or [wiki/FAQ](https://wiki.miscord.net/FAQ))
|
32 |
|
33 | ## How Can I Contribute?
|
34 |
|
35 | ### Reporting Bugs
|
36 |
|
37 | This section guides you through submitting a bug report for Miscord. Following these guidelines helps maintainers and the community understand your report :pencil:, reproduce the behavior :computer: :computer:, and find related reports :mag_right:.
|
38 |
|
39 | Before creating bug reports, please check [this list](#before-submitting-a-bug-report) as you might find out that you don't need to create one. When you are creating a bug report, please [include as many details as possible](#how-do-i-submit-a-good-bug-report). Fill out [the required template](.github/ISSUE_TEMPLATE/Bug_report.md), the information it asks for helps us resolve issues faster.
|
40 |
|
41 | > **Note:** If you find a **Closed** issue that seems like it is the same thing that you're experiencing, open a new issue and include a link to the original issue in the body of your new one.
|
42 |
|
43 | #### Before Submitting A Bug Report
|
44 |
|
45 | * **Check the [FAQ](https://github.com/miscord/miscord/wiki/FAQ) and try changing log level.** You might be able to find the cause of the problem and fix things yourself. Most importantly, check if you can reproduce the problem [in the latest version of Miscord](https://github.com/miscord/miscord/wiki/Updating).
|
46 | * **Perform a [cursory search](https://github.com/miscord/miscord/issues)** to see if the problem has already been reported. If it has **and the issue is still open**, add a comment to the existing issue instead of opening a new one.
|
47 |
|
48 | #### How Do I Submit A (Good) Bug Report?
|
49 |
|
50 | Bugs are tracked as [GitHub issues](https://guides.github.com/features/issues/). You can create an issue in the [miscord](https://github.com/miscord/miscord/issues) repository and provide the following information by filling in [the template](.github/ISSUE_TEMPLATE/Bug_report.md).
|
51 |
|
52 | Explain the problem and include additional details to help maintainers reproduce the problem:
|
53 |
|
54 | * **Use a clear and descriptive title** for the issue to identify the problem.
|
55 | * **Describe the exact steps which reproduce the problem** in as many details as possible. For example, start by explaining how you started Miscord, e.g. which command exactly you used in the terminal, or how you started Miscord otherwise.
|
56 | * **Provide specific examples to demonstrate the steps**. Include links to files or GitHub projects, or copy/pasteable snippets, which you use in those examples. If you're providing snippets in the issue, use [Markdown code blocks](https://help.github.com/articles/markdown-basics/#multiple-lines).
|
57 | * **Describe the behavior you observed after following the steps** and point out what exactly is the problem with that behavior.
|
58 | * **Explain which behavior you expected to see instead and why.**
|
59 | * **If you're reporting that Miscord crashed**, include a crash report with a stack trace from the operating system. Log file should be in folder `logs/` alongside your config. Include the crash report in the issue in a [code block](https://help.github.com/articles/markdown-basics/#multiple-lines), a [file attachment](https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/), or put it in a [gist](https://gist.github.com/) and provide link to that gist.
|
60 | * **If the problem wasn't triggered by a specific action**, describe what you were doing before the problem happened and share more information using the guidelines below.
|
61 |
|
62 | Provide more context by answering these questions:
|
63 |
|
64 | * **Did the problem start happening recently** (e.g. after updating to a new version of Miscord) or was this always a problem?
|
65 | * If the problem started happening recently, **can you reproduce the problem in an older version of Miscord?** What's the most recent version in which the problem doesn't happen? You can download older versions of Miscord from [the releases page](https://github.com/miscord/miscord/releases) or with `npm install -g miscord@version`.
|
66 | * **Can you reliably reproduce the issue?** If not, provide details about how often the problem happens and under which conditions it normally happens.
|
67 |
|
68 | Include details about your configuration and environment:
|
69 |
|
70 | * **Which version of Miscord are you using?** You can get the exact version by running `miscord -v` in your terminal, or by checking the Discord bot's Presence.
|
71 | * **What's the name and version of the OS you're using**
|
72 | * **Which version of NPM you're using (ignore for binary)**
|
73 |
|
74 | ### Suggesting Enhancements
|
75 |
|
76 | This section guides you through submitting an enhancement suggestion for Miscord, including completely new features and minor improvements to existing functionality. Following these guidelines helps maintainers and the community understand your suggestion :pencil: and find related suggestions :mag_right:.
|
77 |
|
78 | Before creating enhancement suggestions, please check [this list](#before-submitting-an-enhancement-suggestion) as you might find out that you don't need to create one. When you are creating an enhancement suggestion, please [include as many details as possible](#how-do-i-submit-a-good-enhancement-suggestion). Fill in [the template](.github/ISSUE_TEMPLATE/Feature_request.md), including the steps that you imagine you would take if the feature you're requesting existed.
|
79 |
|
80 | #### Before Submitting An Enhancement Suggestion
|
81 |
|
82 | * **Check the [beta version](https://github.com/miscord/miscord/wiki/Beta-version)** — you might discover that the enhancement is already available. Most importantly, check if you're using [the latest version of Miscord](https://github.com/miscord/miscord/wiki/Updating).
|
83 | * **Perform a [search](https://github.com/miscord/miscord/issues?q=is%3Aissue+is%3Aopen+label%3Aenhancement+sort%3Aupdated-desc)** to see if the enhancement has already been suggested. If it has, add a comment to the existing issue instead of opening a new one.
|
84 |
|
85 | #### How Do I Submit A (Good) Enhancement Suggestion?
|
86 |
|
87 | Enhancement suggestions are tracked as [GitHub issues](https://guides.github.com/features/issues/). You can create an issue in the [miscord](https://github.com/miscord/miscord/issues) repository and provide the following information:
|
88 |
|
89 | * **Use a clear and descriptive title** for the issue to identify the suggestion.
|
90 | * **Provide a step-by-step description of the suggested enhancement** in as many details as possible.
|
91 | * **Provide specific examples to demonstrate the steps**. Include copy/pasteable snippets which you use in those examples, as [Markdown code blocks](https://help.github.com/articles/markdown-basics/#multiple-lines).
|
92 | * **Describe the current behavior** and **explain which behavior you expected to see instead** and why.
|
93 | * **Explain why this enhancement would be useful** to most Miscord users.
|
94 | * **Specify which version of Miscord you're using.** You can get the exact version by running `miscord -v` in your terminal, or by checking the Discord bot's Presence.
|
95 | * **Specify the name and version of the OS you're using.**
|
96 |
|
97 | ### Your First Code Contribution
|
98 |
|
99 | Unsure where to begin contributing to Miscord? You can start by looking through these `beginner` and `help-wanted` issues:
|
100 |
|
101 | * [Beginner issues][beginner] - issues which should only require a few lines of code, and a test or two.
|
102 | * [Help wanted issues][help-wanted] - issues which should be a bit more involved than `beginner` issues.
|
103 |
|
104 | Both issue lists are sorted by activity.
|
105 |
|
106 | ### Pull Requests
|
107 |
|
108 | The process described here has several goals:
|
109 |
|
110 | - Maintain Miscord's quality
|
111 | - Fix problems that are important to users
|
112 | - Engage the community in working toward the best possible Miscord
|
113 | - Enable a sustainable system for Miscord's maintainers to review contributions
|
114 |
|
115 | Please follow these steps to have your contribution considered by the maintainers:
|
116 |
|
117 | 1. Follow the [styleguides](#styleguides)
|
118 | 2. Make sure you're creating a PR to `dev` and not `master`
|
119 | 3. After you submit your pull request, verify that all [status checks](https://help.github.com/articles/about-status-checks/) are passing <details><summary>What if the status checks are failing?</summary>If a status check is failing, and you believe that the failure is unrelated to your change, please leave a comment on the pull request explaining why you believe the failure is unrelated. A maintainer will re-run the status check for you. If we conclude that the failure was a false positive, then we will open an issue to track that problem with our status check suite.</details>
|
120 |
|
121 | While the prerequisites above must be satisfied prior to having your pull request reviewed, the reviewer(s) may ask you to complete additional design work, tests, or other changes before your pull request can be ultimately accepted.
|
122 |
|
123 | ## Styleguides
|
124 |
|
125 | ### Git Commit Messages
|
126 |
|
127 | * Start the commit message with [an applicable emoji](https://gitmoji.carloscuesta.me/)
|
128 | * Use the past tense ("added feature", not "add feature")
|
129 | * Don't capitalize ("added feature", not "Added feature")
|
130 | * Limit the first line to 72 characters or less
|
131 | * Reference issues and pull requests liberally after the first line
|
132 |
|
133 | ### JavaScript Styleguide
|
134 |
|
135 | All JavaScript must adhere to [JavaScript Standard Style](https://standardjs.com/).
|
136 |
|
137 | > Heavily inspired by [Atom's Contributing page](https://github.com/atom/atom/blob/master/CONTRIBUTING.md)
|
138 |
|
139 | [beginner]:https://github.com/miscord/miscord/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22beginner%22
|
140 | [help-wanted]:https://github.com/miscord/miscord/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22help+wanted%22
|