zetta/test/test_api.js

var assert = require('assert');
var http = require('http');
var os = require('os');
var request = require('supertest');
var spdy = require('spdy');
var zetta = require('../');
var Query = require('calypso').Query;
var rels = require('zetta-rels');
var zettacluster = require('zetta-cluster');
var Scout = require('./fixture/example_scout');
var Driver = require('./fixture/example_driver');
var HttpDriver = require('./fixture/example_http_driver');
var Registry = require('./fixture/mem_registry');
var PeerRegistry = require('./fixture/mem_peer_registry');

function getHttpServer(app) {
  return app.httpServer.server;
}

function getBody(fn) {
  return function(res) {
    try {
      if(res.text) {
        var body = JSON.parse(res.text);
      } else {
        var body = '';
      }
    } catch(err) {
      throw new Error('Failed to parse json body');
    }

    fn(res, body);
  }
}

function checkDeviceOnRootUri(entity) {
  assert(entity.class.indexOf('device') >= 0);
  assert(entity.class.indexOf(entity.properties.type) >= 0);
  assert.deepEqual(entity.rel, ["http://rels.zettajs.io/device"]);
  
  assert(entity.properties.name);
  assert(entity.properties.type);
  assert(entity.properties.state);
  assert(!entity.actions); // should not have actions on it

  assert(entity.links);
  hasLinkRel(entity.links, rels.self);
  hasLinkRel(entity.links, rels.server);
  hasLinkRel(entity.links, rels.type);
  hasLinkRel(entity.links, rels.edit);
}

function hasLinkRel(links, rel, title, href) {
  var found = false;

  links.forEach(function(link) {
    if(link.rel.indexOf(rel) != -1) {
      found = true;

      if(title !== undefined && link.title !== title) {
        throw new Error('link title does not match');
      }

      if(href !== undefined && link.href !== href) {
        throw new Error('link href does not match');
      }
    }
  });

  if(!found) {
    throw new Error('Link rel:'+rel+' not found in links');
  }
}


describe('Zetta Api', function() {
  var reg = null;
  var peerRegistry = null;

  beforeEach(function() {
    reg = new Registry();
    peerRegistry = new PeerRegistry();
  });

  it('updates href hosts using x-forwarded-host header', function(done) {
    var app = zetta({ registry: reg, peerRegistry: peerRegistry  })
        .silent()
        .name('local')
        ._run(function(err) {
          if (err) {
            return done(err);
          }

          request(getHttpServer(app))
            .get('/')
            .set('x-forwarded-host', 'google.com')
            .expect(getBody(function(res, body) {
              var self = body.links.filter(function(link) { return link.rel.indexOf('self') >= 0; })[0];
              assert.equal(self.href, 'http://google.com/');
            }))
            .end(done);
        });
  })

  it('allow for x-forwarded-host header to be disabled', function(done) {
    var app = zetta({ registry: reg, peerRegistry: peerRegistry, useXForwardedHostHeader: false  })
        .silent()
        .name('local')
        ._run(function(err) {
          if (err) {
            return done(err);
          }

          request(getHttpServer(app))
            .get('/')
            .set('x-forwarded-host', 'google.com')
            .expect(getBody(function(res, body) {
              var self = body.links.filter(function(link) { return link.rel.indexOf('self') >= 0; })[0];
              assert.notEqual(self.href, 'http://google.com/');
            }))
            .end(done);
        });
  })

  describe('/servers/<peer id> ', function() {
    var app = null;
    var url = null;

    beforeEach(function(done) {
      app = zetta({ registry: reg, peerRegistry: peerRegistry })
        .silent()
        .properties({ custom: 123 })
        .use(Scout)
        .use(HttpDriver)
        .name('local')
        .expose('*')
        ._run(done);

      url = '/servers/'+app._name;
    });

    it('should have content type application/vnd.siren+json', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect('Content-Type', 'application/vnd.siren+json', done);
    });

    it('should return status code 200', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(200, done);
    });

    it('should have class ["server"]', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert.deepEqual(body.class, ['server']);
        }))
        .end(done);
    });

    it('should have proper name and id property', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert.equal(body.properties.name, 'local');
        }))
        .end(done);
    });

    it('should have custom properties in resp', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert.equal(body.properties.name, 'local');
          assert.equal(body.properties.custom, 123);
        }))
        .end(done);
    });

    it('should have self link and log link', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.links);
          hasLinkRel(body.links, 'self');
          hasLinkRel(body.links, 'monitor');
        }))
        .end(done);
    });

    it('should have a metadata link', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.links);
          hasLinkRel(body.links, rels.metadata);
        }))
        .end(done);
    });

    it('should have monitor log link formatted correctly for HTTP requests', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {          
          var link = body.links.filter(function(l) {
            return l.rel.indexOf('monitor') > -1;
          })[0];
          var obj = require('url').parse(link.href, true);
          assert.equal(obj.protocol, 'ws:');
          assert(obj.query.topic);
        }))
        .end(done);
    });

    it('should have monitor log link formatted correctly for SPDY requests', function(done) {
      var a = getHttpServer(app);

      if (!a.address()) a.listen(0);

      var agent = spdy.createAgent({
        host: '127.0.0.1',
        port: a.address().port,
        spdy: {
          plain: true,
          ssl: false
        }
      });

      var request = http.get({
        host: '127.0.0.1',
        port: a.address().port,
        path: url,
        agent: agent
      }, function(response) {

        var buffers = [];
        response.on('readable', function() {
          var data;
          while ((data = response.read()) !== null) {
            buffers.push(data);
          }
        });

        response.on('end', function() {
          var body = JSON.parse(Buffer.concat(buffers));
          var link = body.links.filter(function(l) {
            return l.rel.indexOf('monitor') > -1;
          })[0];
          var obj = require('url').parse(link.href, true);
          assert.equal(obj.protocol, 'http:');
          assert(obj.query.topic);
          agent.close();
        });

        response.on('end', done);
      }).end();
    });

    it('should not have an events link for SPDY requests', function(done) {
      var a = getHttpServer(app);

      if (!a.address()) a.listen(0);

      var agent = spdy.createAgent({
        host: '127.0.0.1',
        port: a.address().port,
        spdy: {
          plain: true,
          ssl: false
        }
      });

      var request = http.get({
        host: '127.0.0.1',
        port: a.address().port,
        path: '/',
        agent: agent
      }, function(response) {

        var buffers = [];
        response.on('readable', function() {
          var data;
          while ((data = response.read()) !== null) {
            buffers.push(data);
          }
        });

        response.on('end', function() {
          var body = JSON.parse(Buffer.concat(buffers));
          var links = body.links.filter(function(l) {
            return l.rel.indexOf('http://rels.zettajs.io/events') > -1;
          });
          assert.equal(links.length, 0);
          agent.close();
        });

        response.on('end', done);
      }).end();
    });  

    it('should have valid entities', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.entities);
          assert.equal(body.entities.length, 1);
          checkDeviceOnRootUri(body.entities[0]);
        }))
        .end(done);
    });

    it('should have one action', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.actions);
          assert.equal(body.actions.length, 1);
        }))
        .end(done);
    });

    it('should accept remote devices of type testdriver', function(done) {
      request(getHttpServer(app))
        .post(url + '/devices')
        .send('type=testdriver')
        .end(function(err, res) {
          getBody(function(res, body) {
            assert.equal(res.statusCode, 201);
            var query = Query.of('devices');
            reg.find(query, function(err, machines) {
              assert.equal(machines.length, 2);
              assert.equal(machines[1].type, 'testdriver');
              done();
            });
          })(res);
        });
    });

    it('should not accept a remote device of type foo', function(done) {
      request(getHttpServer(app))
        .post(url + '/devices')
        .send('type=foo')
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 404);
        }))
        .end(done);
    });

    it('should accept remote devices of type testdriver, and allow them to set their own id properties', function(done) {
      request(getHttpServer(app))
        .post(url + '/devices')
        .send('type=testdriver&id=12345&name=test')
        .end(function(err, res) {
          getBody(function(res, body) {
            assert.equal(res.statusCode, 201);
            var query = Query.of('devices').where('id', { eq: '12345'});
            reg.find(query, function(err, machines) {
              assert.equal(machines.length, 1);
              assert.equal(machines[0].type, 'testdriver');
              assert.equal(machines[0].id, '12345');            
              done();
            });
          })(res);
        });
    });

    it('query for device should respond with properly formated api response', function(done) {
      request(getHttpServer(app))
        .get(url+'?server=local&ql=where%20type="testdriver"')
        .expect(getBody(function(res, body) {
          assert(body.entities);
          assert.equal(body.entities.length, 1);
          checkDeviceOnRootUri(body.entities[0]);
        }))
        .end(done);
    });
  });

  describe('/', function() {
    var app = null;

    beforeEach(function() {
      app = zetta({ registry: reg, peerRegistry: peerRegistry })
        .silent()
        .use(Scout)
        .name('local')
        .expose('*')
        ._run();
    });

    it('should have content type application/vnd.siren+json', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect('Content-Type', 'application/vnd.siren+json', done);
    });

    it('should have status code 200', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect(200, done);
    });

    it('body should contain class ["root"]', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect(getBody(function(res, body) {
          assert.deepEqual(body.class, ['root']);
      }))
      .end(done)
    });


    it('body should contain links property', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect(getBody(function(res, body) {
          assert.equal(body.links.length, 4);
          hasLinkRel(body.links, 'self');
        }))
        .end(done)
    });

    it('links should contain rel to server', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, rels.server);
        }))
        .end(done)
    });

    it('should contain link for event stream', function(done) {
      request(getHttpServer(app))
        .get('/')
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, rels.events);
        }))
        .end(done)
    });

    it('should use a default server name if none has been provided', function(done) {
      var app = zetta({ registry: reg, peerRegistry: peerRegistry }).silent()._run();

      request(getHttpServer(app))
        .get('/')
        .expect(getBody(function(res, body) {
          var self = body.links.filter(function(link) {
            return link.rel.indexOf(rels.server) !== -1;
          })[0];

          assert.equal(self.title, os.hostname());
        }))
        .end(done);
    });
  });

  describe('/peer-management', function() {
    var app = null;

    before(function(done) {
      peerRegistry.save({
        id: '12341234',
        name: 'test-peer'
      }, done);
    });

    beforeEach(function(done) {
      app = zetta({ registry: reg, peerRegistry: peerRegistry })
        .silent()
        .use(Scout)
        .name('local')
        .expose('*')
        ._run(done);
    });

    it('should have content type application/vnd.siren+json', function(done) {
      request(getHttpServer(app))
        .get('/peer-management')
        .expect('Content-Type', 'application/vnd.siren+json', done);
    });

    it('should return status code 200', function(done) {
      request(getHttpServer(app))
        .get('/peer-management')
        .expect(200, done);
    });

    it('should have class ["peer-management"]', function(done) {
      request(getHttpServer(app))
        .get('/peer-management')
        .expect(getBody(function(err, body) {
          assert.deepEqual(body.class, ['peer-management']);
        }))
        .end(done);
    });

    it('subentities should have rel ["item"]', function(done) {
      peerRegistry.save({ id: '0' }, function() {
        request(getHttpServer(app))
          .get('/peer-management')
          .expect(getBody(function(err, body) {
            body.entities.forEach(function(entity) {
              assert(entity.rel.indexOf('item') >= 0)
            })
          }))
          .end(done);
      });
    });

    it('should list saved peers', function(done) {
      peerRegistry.save({ id: '0' }, function() {
        request(getHttpServer(app))
          .get('/peer-management')
          .expect(getBody(function(err, body) {
            assert.equal(body.entities.length, 1);
          }))
          .end(done);
      });
    });

    it('should allow the querying of peers with the ql parameter', function(done) {
      peerRegistry.save({ id: '1', type: 'initiator'}, function() {
        request(getHttpServer(app))
          .get('/peer-management?ql=where%20type%3D%22initiator%22')
          .expect(getBody(function(err, body) {
            assert.equal(body.entities.length, 1);
            var entity = body.entities[0];
            assert.equal(entity.properties.id, '1');  
          }))
          .end(done);  
      });  
    });

    describe('#link', function() {
      it('should return status code 202', function(done) {
        request(getHttpServer(app))
          .post('/peer-management')
          .send('url=http://testurl')
          .expect(202, done);
      });

      it('should return a Location header', function(done) {
        request(getHttpServer(app))
          .post('/peer-management')
          .send('url=http://testurl')
          .expect('Location', /^http.+/)
          .end(done);
      });
    });

    describe('#show', function() {
      it('should return the peer item representation', function(done) {
        var id = '1234-5678-9ABCD';
        peerRegistry.save({ id: id }, function() {
          request(getHttpServer(app))
            .get('/peer-management/' + id)
            .expect(200, done);
        });
      });
    });
  });

  describe('/devices of server', function() {
    var app = null;

    beforeEach(function(done) {
      app = zetta({ registry: reg, peerRegistry: peerRegistry })
        .silent()
        .use(Scout)
        .name('local')
        .expose('*')
        ._run(done);
    });

    it('should have content type application/vnd.siren+json', function(done) {
      request(getHttpServer(app))
        .get('/devices')
        .expect('Content-Type', 'application/vnd.siren+json', done);
    });

    it('should return status code 200', function(done) {
      request(getHttpServer(app))
        .get('/devices')
        .expect(200, done);
    });

    it('should have class ["devices"]', function(done) {
      request(getHttpServer(app))
        .get('/devices')
        .expect(getBody(function(res, body) {
          assert.deepEqual(body.class, ['devices']);
        }))
        .end(done);
    });

    it('should have one valid entity', function(done) {
      request(getHttpServer(app))
        .get('/devices')
        .expect(getBody(function(res, body) {
          assert(body.entities);
          assert.equal(body.entities.length, 1);
          checkDeviceOnRootUri(body.entities[0]);
          hasLinkRel(body.links, 'self');
        }))
        .end(done);
    });
  });




  describe('/servers/:id/devices/:id', function() {
    var app = null;
    var url = null;
    var device = null;

    beforeEach(function(done) {
      app = zetta({ registry: reg, peerRegistry: peerRegistry })
        .silent()
        .use(Scout)
        .name('local')
        .expose('*')
        ._run(function() {
          device = app.runtime._jsDevices[Object.keys(app.runtime._jsDevices)[0]];
          url = '/servers/' + app._name + '/devices/' + device.id;
          done();
        });
    });

    it('should have content type application/vnd.siren+json', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect('Content-Type', 'application/vnd.siren+json', done);
    });

    it('class should be ["device", ":type"]', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.class.indexOf('device') >= 0);
          assert(body.class.indexOf(body.properties.type) >= 0);
        }))
        .end(done);
    });

    /*
          checkDeviceOnRootUri(body.entities[0]);
          hasLinkRel(body.links, 'self');

     */

    it('properties should match expected', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert(body.properties);
          assert.equal(body.properties.name, device.name);
          assert.equal(body.properties.type, device.type);
          assert.equal(body.properties.id, device.id);
          assert.equal(body.properties.state, device.state);
        }))
        .end(done);
    });

    it('device should have action change', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert.equal(body.actions.length, 7);
          var action = body.actions[0];
          assert.equal(action.name, 'change');
          assert.equal(action.method, 'POST');
          assert(action.href);
          assert.deepEqual(action.fields[0], { name: 'action', type: 'hidden', value: 'change' });
        }))
        .end(done);
    });

    it('device actions should have class "transition"', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          assert.equal(body.actions.length, 7);
          body.actions.forEach(function(action) {
            assert(action.class.indexOf('transition') >= 0);
          })
        }))
        .end(done);
    });


    it('device should have self link', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, 'self');
        }))
        .end(done);
    });

    it('device should have edit link', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, 'edit');
        }))
        .end(done);
    });

    it('device should have up link to server', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, 'up', 'local');
        }))
        .end(done);
    });

    it('device should have monitor link for bar', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          hasLinkRel(body.links, 'monitor');
        }))
        .end(done);
    });

    it('disabling a stream should remove it from the API.', function(done) {
      Object.keys(app.runtime._jsDevices).forEach(function(name) {
        var device = app.runtime._jsDevices[name];
        device.disableStream('foo');  
      });

      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          var foo = body.links.filter(function(link) {
            return link.title === 'foo';
          });

          assert.equal(foo.length, 0);
        }))
        .end(done);
    });

    it('enabling a stream should show it in the API.', function(done) {
      var device = null;
      Object.keys(app.runtime._jsDevices).forEach(function(name) {
        device = app.runtime._jsDevices[name];
        device.disableStream('foo');  
        device.enableStream('foo');
      });

      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          var foo = body.links.filter(function(link) {
            return link.title === 'foo';
          });

          assert.equal(foo.length, 1);
        }))
        .end(done);
    });

    it('device should have monitor link for bar formatted correctly for HTTP requests', function(done) {
      request(getHttpServer(app))
        .get(url)
        .expect(getBody(function(res, body) {
          var fooBar = body.links.filter(function(link) {
            return link.title === 'foobar';
          });

          hasLinkRel(fooBar, rels.binaryStream);
          var parsed = require('url').parse(fooBar[0].href);
          assert.equal(parsed.protocol, 'ws:');
        }))
        .end(done);
    });

    it('should have a monitor link for bar formatted correctly for SPDY requests', function(done) {
      var a = getHttpServer(app);

      if (!a.address()) a.listen(0);

      var agent = spdy.createAgent({
        host: '127.0.0.1',
        port: a.address().port,
        spdy: {
          plain: true,
          ssl: false
        }
      });

      var request = http.get({
        host: '127.0.0.1',
        port: a.address().port,
        path: url,
        agent: agent
      }, function(response) {

        var buffers = [];
        response.on('readable', function() {
          var data;
          while ((data = response.read()) !== null) {
            buffers.push(data);
          }
        });

        response.on('end', function() {
          var body = JSON.parse(Buffer.concat(buffers));
          var fooBar = body.links.filter(function(link) {
            return link.title === 'foobar';
          });

          hasLinkRel(fooBar, rels.binaryStream);
          var parsed = require('url').parse(fooBar[0].href);
          assert.equal(parsed.protocol, 'http:');
          agent.close();
        });

        response.on('end', done);
      }).end();
    });

    it('device action should return a 400 status code on a missing request body', function(done) {
      request(getHttpServer(app))
        .post(url)
        .send()
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 400);
        }))
        .end(done);
    });

    it('device action should return a 400 status code on an invalid request body', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .send('{ "what": "invalid" }')
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 400);
        }))
        .end(done);
    });

    it('device action should work', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .send({ action: 'test', value: 123 })
        .expect(getBody(function(res, body) {
          assert.equal(body.properties.value, 123);
          hasLinkRel(body.links, 'monitor');
        }))
        .end(done);
    });

    it('device action should support extended characters', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .send({ action: 'test-text', value: "🙌💸🙌" })
        .expect(getBody(function(res, body) {
          assert.equal(body.properties.message, "🙌💸🙌");
        }))
        .end(done);
    });

    var createTransitionArgTest = function(action, testType, input) {
      it('api should decode transition args to ' + testType + ' for ' + action, function(done) {
        var device = app.runtime._jsDevices[Object.keys(app.runtime._jsDevices)[0]];
        
        var orig = device._transitions[action].handler;
        device._transitions[action].handler = function(x) {
          assert.equal(typeof x, testType);
          orig.apply(device, arguments);
        };
        
        request(getHttpServer(app))
          .post(url)
          .type('form')
          .expect(200)
          .send({ action: action, value: input })
          .end(done);
      });
    };
    
    createTransitionArgTest('test-number', 'number', 123)
    createTransitionArgTest('test-text', 'string', 'Hello');
    createTransitionArgTest('test-none', 'string', 'Anything');
    createTransitionArgTest('test-date', 'object', '2015-01-02');

    it('api should respond with 400 when argument is not expected number', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .expect(400)
        .expect(getBody(function(res, body) {
          assert(body.class.indexOf('input-error') > -1);
          assert.equal(body.properties.errors.length, 1);
        }))
        .send({ action: 'test-number', value: 'some string' })
        .end(done);
    })

    it('api should respond with 400 when argument is not expected Date', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .expect(400)
        .expect(getBody(function(res, body) {
          assert(body.class.indexOf('input-error') > -1);
          assert.equal(body.properties.errors.length, 1);
        }))
        .send({ action: 'test-date', value: 'some string' })
        .end(done);
    })

    it('device action should return 400 when not available.', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .send({ action: 'prepare' })
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 400);
        }))
        .end(done);
    });

    it('should return 500 when a error is passed in a callback of device driver', function(done) {
      request(getHttpServer(app))
        .post(url)
        .type('form')
        .send({ action: 'error', value: 'some error' })
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 500);
        }))
        .end(done);
    });

    it('should support device updates using PUT', function(done) {
      request(getHttpServer(app))
        .put(url)
        .type('json')
        .send({ bar: 2, value: 3 })
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 200);
          assert.equal(body.properties.bar, 2);
          assert.equal(body.properties.value, 3);
        }))
        .end(done);
    });

    it('should support device deletes using DELETE', function(done) {
      request(getHttpServer(app))
        .del(url)
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 204);
          assert.equal(Object.keys(app.runtime._jsDevices).length, 0);
        }))
        .end(done);

    });

    it('remoteDestroy hook should prevent the device from being destroyed with a DELETE', function(done) {
      var deviceKey = Object.keys(app.runtime._jsDevices)[0];
      var device = app.runtime._jsDevices[deviceKey];

      var remoteDestroy = function(cb) {
        cb(null, false);  
      }

      device._remoteDestroy = remoteDestroy.bind(device);

      request(getHttpServer(app))
        .del(url)
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 500);
          assert.equal(Object.keys(app.runtime._jsDevices).length, 1);
        }))
        .end(done);

    });

    it('remoteDestroy hook should prevent the device from being destroyed with a DELETE if callback has an error', function(done) {
      var deviceKey = Object.keys(app.runtime._jsDevices)[0];
      var device = app.runtime._jsDevices[deviceKey];

      var remoteDestroy = function(cb) {
        cb(new Error('Oof! Ouch!'));  
      }

      device._remoteDestroy = remoteDestroy.bind(device);

      request(getHttpServer(app))
        .del(url)
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 500);
          assert.equal(Object.keys(app.runtime._jsDevices).length, 1);
        }))
        .end(done);

    });

    it('remoteDestroy hook should allow the device to be destroyed when callback is called with true', function(done) {
      var deviceKey = Object.keys(app.runtime._jsDevices)[0];
      var device = app.runtime._jsDevices[deviceKey];

      var remoteDestroy = function(cb) {
        cb(null, true);  
      }

      device._remoteDestroy = remoteDestroy.bind(device);

      request(getHttpServer(app))
        .del(url)
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 204);
          assert.equal(Object.keys(app.runtime._jsDevices).length, 0);
        }))
        .end(done);

    });

    it('should not overwrite monitor properties using PUT', function(done) {
      request(getHttpServer(app))
        .put(url)
        .type('json')
        .send({ foo: 1 })
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 200);
          assert.equal(body.properties.foo, 0);
        }))
        .end(done); 
     });

    it('should return a 404 when updating a non-existent device', function(done) {
      request(getHttpServer(app))
        .put(url + '1234567890')
        .type('json')
        .send({ foo: 1, bar: 2, value: 3 })
        .expect(function(res) {
          assert.equal(res.statusCode, 404);
        })
        .end(done);
    });

    it('should return a 400 when updating with a Content-Range header', function(done) {
      request(getHttpServer(app))
        .put(url)
        .set('Content-Range', 'bytes 0-499/1234')
        .type('json')
        .send({ foo: 1, bar: 2, value: 3 })
        .expect(function(res) {
          assert.equal(res.statusCode, 400);
        })
        .end(done);
    });

    it('should return a 400 when receiving invalid JSON input', function(done) {
      request(getHttpServer(app))
        .put(url)
        .type('json')
        .send('{"name":}')
        .expect(function(res) {
          assert.equal(res.statusCode, 400);
        })
        .end(done);
    });

    it('should not include reserved fields on device updates', function(done) {
      var input = { foo: 1, bar: 2, value: 3, id: 'abcdef',
        _x: 4, type: 'h', state: 'yo', streams: 's' };

      request(getHttpServer(app))
        .put(url)
        .type('json')
        .send(input)
        .expect(getBody(function(res, body) {
          assert.equal(res.statusCode, 200);
          assert.notEqual(body.properties.id, 'abcdef');
          assert.notEqual(body.properties._x, 4);
          assert.notEqual(body.properties.streams, 's');
          assert.notEqual(body.properties.state, 'yo');
          assert.notEqual(body.properties.type, 'h');
        }))
        .end(done);
    });
 });

  describe('Proxied requests', function() {
    var base = null;
    var cloudUrl = null;
    var cluster = null;

    beforeEach(function(done) {
      cluster = zettacluster({ zetta: zetta })
        .server('cloud')
        .server('detroit', [Scout], ['cloud'])
        .server('sanjose', [Scout], ['cloud'])
        .on('ready', function(){
          cloudUrl = 'localhost:' + cluster.servers['cloud']._testPort;
          base = 'localhost:' + cluster.servers['cloud']._testPort + '/servers/' + cluster.servers['cloud'].locatePeer('detroit');
          setTimeout(done, 300);
        })
        .run(function(err) {
          console.log(err)
          if (err) {
            done(err);
          }
        });
    });

    afterEach(function(done) {
      cluster.stop();
      setTimeout(done, 10); // fix issues with server not being closed before a new one starts
    });

    it('zetta should not crash when req to hub is pending and hub disconnects', function(done) {
      http.get('http://' + base, function(res) {
        assert.equal(res.statusCode, 502);
        done();
      }).on('socket', function(socket) {
        socket.on('connect', function() {
          cluster.servers['cloud'].httpServer.peers['detroit'].close();
        });
      })
    })

    it('zetta should return 404 on non-existent peer', function(done) {
      http.get('http://' + cloudUrl + '/servers/some-peer', function(res) {
        assert.equal(res.statusCode, 404);
        done();
      })
    })

    it('zetta should return 404 on disconnected peer', function(done) {
      cluster.servers['detroit']._peerClients[0].close()
      http.get('http://' + cloudUrl + '/servers/detroit', function(res) {
        assert.equal(res.statusCode, 404);
        done();
      })
    })

    it('device action should support extended characters throw a proxied connection', function(done) {

      var device = cluster.servers['detroit'].runtime._jsDevices[Object.keys(cluster.servers['detroit'].runtime._jsDevices)[0]];

      request(getHttpServer(cluster.servers['cloud']))
        .post('/servers/detroit/devices/' + device.id)
        .type('form')
        .send({ action: 'test-text', value: "🙌💸🙌" })
        .expect(getBody(function(res, body) {
          assert.equal(body.properties.message, "🙌💸🙌");
        }))
        .end(done);
    });


  })

  describe('Server name issues', function() {
    var cluster;
    var hubName = 'hub 1';
    var getServer = function(peerName) {
      return cluster.servers[peerName].httpServer.server;
    };
    beforeEach(function(done) {
      cluster = zettacluster({ zetta: zetta })
        .server('cloud')
        .server(hubName, [Scout], ['cloud'])
        .on('ready', done)
        .run(function(err) {
          if (err) {
            done(err);
          }
        });
    });

    it('server name with space has correct path to root of server', function(done) {
      request(getServer('cloud'))
        .get('/')
        .expect(getBody(function(res, body) {
          var link = body.links.filter(function(link) { return link.title === hubName})[0];
          var parsed = require('url').parse(link.href);
          assert.equal(decodeURI(parsed.path), '/servers/' + hubName);
        }))
        .end(done);
    })

    it('server name with space has correct path to device', function(done) {
      request(getServer('cloud'))
        .get('/servers/' + hubName)
        .expect(getBody(function(res, body) {
          body.entities.forEach(function(entity) {
            entity.links.forEach(function(link) {
              var parsed = require('url').parse(link.href);
              assert.equal(decodeURI(parsed.path).indexOf('/servers/' + hubName), 0);
            });
          });
        }))
        .end(done);
    })
  })


});