{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/13","repository_url":"https://api.github.com/repos/mansona/ember-get-config","labels_url":"https://api.github.com/repos/mansona/ember-get-config/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/mansona/ember-get-config/issues/13/comments","events_url":"https://api.github.com/repos/mansona/ember-get-config/issues/13/events","html_url":"https://github.com/mansona/ember-get-config/pull/13","id":197432914,"node_id":"MDExOlB1bGxSZXF1ZXN0OTkyODU2Mzc=","number":13,"title":"Don't mutate our own source code","user":{"login":"dfreeman","id":108688,"node_id":"MDQ6VXNlcjEwODY4OA==","avatar_url":"https://avatars.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-23T22:23:54Z","updated_at":"2016-12-29T21:35:37Z","closed_at":"2016-12-29T21:35:37Z","author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/mansona/ember-get-config/pulls/13","html_url":"https://github.com/mansona/ember-get-config/pull/13","diff_url":"https://github.com/mansona/ember-get-config/pull/13.diff","patch_url":"https://github.com/mansona/ember-get-config/pull/13.patch","merged_at":"2016-12-29T21:35:37Z"},"body":"We have an in-repo addon that uses ember-get-config, and it's shared by multiple applications that we often build in parallel with one another. This means that between when this addon emits a new `addon/index.js` for a particular app and when that file actually gets consumed by that app's build, it can get overwritten by the `addon/index.js` for a different app, resulting in a broken import in the final build.\r\n\r\nThis change switches over to emitting the generated `index.js` directly into ember-get-config's broccoli tree, rather than mutating the source in place.","closed_by":{"login":"briarsweetbriar","id":2700872,"node_id":"MDQ6VXNlcjI3MDA4NzI=","avatar_url":"https://avatars.githubusercontent.com/u/2700872?v=4","gravatar_id":"","url":"https://api.github.com/users/briarsweetbriar","html_url":"https://github.com/briarsweetbriar","followers_url":"https://api.github.com/users/briarsweetbriar/followers","following_url":"https://api.github.com/users/briarsweetbriar/following{/other_user}","gists_url":"https://api.github.com/users/briarsweetbriar/gists{/gist_id}","starred_url":"https://api.github.com/users/briarsweetbriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briarsweetbriar/subscriptions","organizations_url":"https://api.github.com/users/briarsweetbriar/orgs","repos_url":"https://api.github.com/users/briarsweetbriar/repos","events_url":"https://api.github.com/users/briarsweetbriar/events{/privacy}","received_events_url":"https://api.github.com/users/briarsweetbriar/received_events","type":"User","site_admin":false},"reactions":{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/13/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/mansona/ember-get-config/issues/13/timeline","performed_via_github_app":null,"state_reason":null}