{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/15","repository_url":"https://api.github.com/repos/mansona/ember-get-config","labels_url":"https://api.github.com/repos/mansona/ember-get-config/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mansona/ember-get-config/issues/15/comments","events_url":"https://api.github.com/repos/mansona/ember-get-config/issues/15/events","html_url":"https://github.com/mansona/ember-get-config/pull/15","id":233001920,"node_id":"MDExOlB1bGxSZXF1ZXN0MTIzNTg3NjIz","number":15,"title":"Remove `included` deprecation warning","user":{"login":"dfreeman","id":108688,"node_id":"MDQ6VXNlcjEwODY4OA==","avatar_url":"https://avatars.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-01T20:33:30Z","updated_at":"2017-06-02T20:44:13Z","closed_at":"2017-06-02T18:44:30Z","author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/mansona/ember-get-config/pulls/15","html_url":"https://github.com/mansona/ember-get-config/pull/15","diff_url":"https://github.com/mansona/ember-get-config/pull/15.diff","patch_url":"https://github.com/mansona/ember-get-config/pull/15.patch","merged_at":"2017-06-02T18:44:30Z"},"body":"I'd like to propose removing the double `included` warning from this addon. A fair amount of time has passed since it was added, and ember-get-config has moved from 0.1.x to 0.2.x since then, which, [by the way `node-semver` reckons things](https://github.com/npm/node-semver#caret-ranges-123-025-004), crosses a \"breaking change\" line and opens the door for things like removing support for/warnings around deprecated behavior. \r\n\r\nThere's currently [an issue in ember-engines](https://github.com/ember-engines/ember-engines/issues/405) (which may or may not be a bug, given that addon's complex build pipeline patches) that's triggering the warning, and it would be great to be able to avoid that.","closed_by":{"login":"briarsweetbriar","id":2700872,"node_id":"MDQ6VXNlcjI3MDA4NzI=","avatar_url":"https://avatars.githubusercontent.com/u/2700872?v=4","gravatar_id":"","url":"https://api.github.com/users/briarsweetbriar","html_url":"https://github.com/briarsweetbriar","followers_url":"https://api.github.com/users/briarsweetbriar/followers","following_url":"https://api.github.com/users/briarsweetbriar/following{/other_user}","gists_url":"https://api.github.com/users/briarsweetbriar/gists{/gist_id}","starred_url":"https://api.github.com/users/briarsweetbriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briarsweetbriar/subscriptions","organizations_url":"https://api.github.com/users/briarsweetbriar/orgs","repos_url":"https://api.github.com/users/briarsweetbriar/repos","events_url":"https://api.github.com/users/briarsweetbriar/events{/privacy}","received_events_url":"https://api.github.com/users/briarsweetbriar/received_events","type":"User","site_admin":false},"reactions":{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/15/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/mansona/ember-get-config/issues/15/timeline","performed_via_github_app":null}