{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/41","repository_url":"https://api.github.com/repos/mansona/ember-get-config","labels_url":"https://api.github.com/repos/mansona/ember-get-config/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/mansona/ember-get-config/issues/41/comments","events_url":"https://api.github.com/repos/mansona/ember-get-config/issues/41/events","html_url":"https://github.com/mansona/ember-get-config/pull/41","id":1212556501,"node_id":"PR_kwDOArijRM42ooZr","number":41,"title":"breaking: re-export configModule to reduce duplication and fix dynamic config","user":{"login":"mansona","id":594890,"node_id":"MDQ6VXNlcjU5NDg5MA==","avatar_url":"https://avatars.githubusercontent.com/u/594890?v=4","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2022-04-22T16:27:35Z","updated_at":"2022-04-22T18:08:26Z","closed_at":"2022-04-22T16:38:03Z","author_association":"OWNER","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/mansona/ember-get-config/pulls/41","html_url":"https://github.com/mansona/ember-get-config/pull/41","diff_url":"https://github.com/mansona/ember-get-config/pull/41.diff","patch_url":"https://github.com/mansona/ember-get-config/pull/41.patch","merged_at":"2022-04-22T16:38:02Z"},"body":"Thanks to @pichfl for the pairing session and deep-diving into ember-cli to get this super neat 👨‍🍳 💋 \r\n\r\nThis is only breaking because if you were relying on dynamic config changes (by altering the config HTML) then before this PR it wasn't working, and now because of this PR it is working 🎉 \r\n\r\nFixes https://github.com/mansona/ember-get-config/issues/39\r\nFixes https://github.com/mansona/ember-get-config/pull/40","closed_by":{"login":"mansona","id":594890,"node_id":"MDQ6VXNlcjU5NDg5MA==","avatar_url":"https://avatars.githubusercontent.com/u/594890?v=4","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"reactions":{"url":"https://api.github.com/repos/mansona/ember-get-config/issues/41/reactions","total_count":1,"+1":0,"-1":0,"laugh":0,"hooray":1,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/mansona/ember-get-config/issues/41/timeline","performed_via_github_app":null,"state_reason":null}