{"url":"https://api.github.com/repos/empress/empress-blog/issues/118","repository_url":"https://api.github.com/repos/empress/empress-blog","labels_url":"https://api.github.com/repos/empress/empress-blog/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/empress/empress-blog/issues/118/comments","events_url":"https://api.github.com/repos/empress/empress-blog/issues/118/events","html_url":"https://github.com/empress/empress-blog/pull/118","id":866990064,"node_id":"MDExOlB1bGxSZXF1ZXN0NjIyNzUwNzE1","number":118,"title":"Move blog and url services to addon folder","user":{"login":"jelhan","id":4965703,"node_id":"MDQ6VXNlcjQ5NjU3MDM=","avatar_url":"https://avatars.githubusercontent.com/u/4965703?v=4","gravatar_id":"","url":"https://api.github.com/users/jelhan","html_url":"https://github.com/jelhan","followers_url":"https://api.github.com/users/jelhan/followers","following_url":"https://api.github.com/users/jelhan/following{/other_user}","gists_url":"https://api.github.com/users/jelhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jelhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelhan/subscriptions","organizations_url":"https://api.github.com/users/jelhan/orgs","repos_url":"https://api.github.com/users/jelhan/repos","events_url":"https://api.github.com/users/jelhan/events{/privacy}","received_events_url":"https://api.github.com/users/jelhan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2021-04-25T11:44:43Z","updated_at":"2021-04-27T09:08:27Z","closed_at":"2021-04-27T09:08:27Z","author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/empress/empress-blog/pulls/118","html_url":"https://github.com/empress/empress-blog/pull/118","diff_url":"https://github.com/empress/empress-blog/pull/118.diff","patch_url":"https://github.com/empress/empress-blog/pull/118.patch","merged_at":"2021-04-27T09:08:27Z"},"body":"This moves the `blog` and `url` services implementation from `app/` to `addon/` folder. Doing so allows consumers to import the service and extend it when customizing.\r\n\r\nApp's configuration can not be imported directly in `addon/` folder. But it could be resolved from owner.\r\n\r\nAn alternative solution is using `@embroider/marcos` instead reading the configuration values at run-time. But that would be a bigger refactoring, which could be done later.","closed_by":{"login":"mansona","id":594890,"node_id":"MDQ6VXNlcjU5NDg5MA==","avatar_url":"https://avatars.githubusercontent.com/u/594890?v=4","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"reactions":{"url":"https://api.github.com/repos/empress/empress-blog/issues/118/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/empress/empress-blog/issues/118/timeline","performed_via_github_app":null}