| 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306 |
1×
1×
1×
1×
1×
1×
1×
1×
1×
1×
1×
15×
15×
15×
15×
9×
9×
9×
9×
9×
9×
1×
1×
8×
8×
7×
7×
1×
1×
7×
7×
8×
8×
2×
1×
1×
8×
7×
7×
24×
24×
1×
1×
7×
7×
6×
6×
1×
7×
7×
1×
1×
1×
7×
7×
7×
8×
8×
5×
6×
5×
5×
5×
1×
4×
7×
4×
4×
4×
4×
4×
4×
13×
9×
5×
4×
4×
4×
4×
1×
1×
4×
4×
1×
1×
3×
1×
3×
7×
7×
1×
1×
1×
1×
10×
10×
10×
10×
10×
1×
1×
9×
9×
1×
1×
9×
1×
1×
8×
8×
22×
21×
20×
20×
65×
26×
118×
3×
17×
17×
17×
17×
53×
20×
40×
14×
13×
13×
17×
4×
| /**
* @license Apache-2.0
* Copyright (C) 2016 The Sitecheck Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
"use strict";
var Check = require('../../check');
var request = require('request');
var url = require('url');
var async = require('async');
const CONSTANTS = require("../../constants.js");
let inputVector = require('../../inputVector.js');
var AutoLogin = require("../../autoLogin.js");
var params = require('../../params.js');
var falsePositives = ["stripe-card-number"]; // stripe.com ajax form
var headers = {
'content-type': 'application/x-www-form-urlencoded',
'accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8',
'accept-encoding': 'gzip, deflate',
'user-agent': 'Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36'
};
/**
* This class checks html forms CSRF security.
* Checks the presence and robustness of CSRF tokens in "private" pages forms.
* Publicly accessible forms are not checked because they're probably never a CSRF menace (Found a counterexample ? please tell or contribute).
*/
module.exports = class CheckCSRF extends Check {
constructor(target) {
super(CONSTANTS.TARGETTYPE.PAGE, CONSTANTS.CHECKFAMILY.SECURITY, false, true, target);
this.ivs = null;
this.ivsNotConnected = null;
this._cancellationToken = null;
}
/**
*
* Procedure :
* - Get list of forms given in the page when connected
* - Get list of forms given in the same page when not connected
* - for each form that exist when connected but not when unconnected, look for the existence of a CSRF token
* - if csrf token does not exist or is note secure, raise an issue.
* @param cancellationToken
*/
_check(cancellationToken, done) {
var self = this;
self._cancellationToken = cancellationToken;
var timeout = 3000;
let arrayOfConnectedOnlyForms = [];
// access url with a connected user
request.get({ url: self.target.uri, timeout: timeout, cancellationToken: cancellationToken, jar: request.sessionJar }, (err, res, body) => {
if (self._handleError(err)) {
done();
return;
}
self.ivs = inputVector.parseHtml(body); // list forms
if (self.ivs.length > 0) {
// access url with an unconnected user
request.get({ url: self.target.uri, timeout: timeout, cancellationToken: cancellationToken, jar: null }, (err, res, body) => {
/* istanbul ignore if */
Iif (self._handleError(err)) {
done();
return;
}
self.ivsNotConnected = inputVector.parseHtml(body);
for (let formConnected of self.ivs) {
let found = false;
for (let formNonConnected of self.ivsNotConnected) {
if (formConnected.isSameVector(formNonConnected)) {
found = true;
break;
}
}
// add form to elligible forms array "arrayOfConnectedOnlyForms"
if (!found) {
// filter out false positives with known field names
// note : this method is weak and should be enhanced. An evolution would be to use phantomJs to execute js and be able to work with handlers, as explained next.
let falsePositive = false;
for (let f of formConnected.fields) {
for (let fp of falsePositives) {
if (f.name && f.name.indexOf(fp) !== -1) {
falsePositive = true;
break;
}
}
}
if (!falsePositive) arrayOfConnectedOnlyForms.push(formConnected);
}
}
for (let iv of arrayOfConnectedOnlyForms) {
let csrfField = self.getCsrfField(iv);
if (!csrfField) {
// Note : this check is prone to false positives in case of ajax forms which don't contain csrf token hidden input but where csrf protection is handled by js code.
// A possibility could be to detect such forms with phantom js by detecting event handlers on forms or form buttons
self._raiseIssue("warning_csrf.xml", null, "Url '" + res.request.uri.href + "' contains a form with no CSRF protection. (This may be a false positive in case of an ajax form).", true);
}
}
// Now, we check if anti-csrf tokens are correctly generated and checked
// Inspired by https://blog.qualys.com/securitylabs/2015/01/14/do-your-anti-csrf-tokens-really-protect-your-applications-from-csrf-attack
self.getAnotherToken(cancellationToken, (ivs2) => {
/* istanbul ignore if */
Iif (typeof ivs2 === Error) {
if (self._handleError(ivs2)) {
done();
return;
}
}
/* istanbul ignore else */
Eif (ivs2 && ivs2.length > 0) {
let goodCouples = [];
for (let iv1 of self.ivs) {
let csrfField1 = self.getCsrfField(iv1);
if (csrfField1) {
for (let iv2 of ivs2) {
if (iv1.isSameVector(iv2)) {
let csrfField2 = self.getCsrfField(iv2);
/* istanbul ignore else */
Eif (csrfField2) {
if (csrfField1.value === csrfField2.value) {
// tokens are the same accross sessions
self._raiseIssue("warning_csrf.xml", null, "Url '" + res.request.uri.href + "' contains a form with a CSRF token that is the same accross different sessions.", true);
} else {
// the form has different anti csrf tokens. Remember them to check they're correctly checked.
goodCouples.push([csrfField1, csrfField2, iv1]);
}
}
}
}
}
}
// check if csrf tokens are checked properly against their respective session by trying to use the anti-csrf token of a session from another session
async.eachSeries(goodCouples, function (couple, callback) {
let csrfField1 = couple[0];
let csrfField2 = couple[1];
let iv = couple[2];
let formData = {};
var actionUrl = url.resolve(self.target.uri, iv.url);
for (let field of iv.fields) {
if (field.name) {
if (field.value) {
formData[field.name] = field.value;
} else {
formData[field.name] = '';
}
}
}
formData[csrfField1.name] = csrfField2.value; // switch csrf token
let req = {
method: iv.method,
url: actionUrl, timeout: 60000, cancellationToken: cancellationToken,
headers: headers,
form: formData,
jar: request.sessionJar,
followRedirect: false
};
if (iv.enctype == "multipart/form-data") {
req.form = undefined;
req.formData = formData;
}
request(req, (err, res, body) => {
if (err) {
// url is unreacheable. remain silent here. It's SEO checks responsibility to check and raise this kind of issue
callback();
return;
}
// woocommerce.com (WordPress) and progressive-sports.co.uk (Concrete 5) send a 302 on success and a 200 otherwise.
// note : Must improve following lines to handle other sites possible behavior.
if (res.statusCode == 302) {
self._raiseIssue("warning_csrf.xml", null, 'Form "' + iv.name + '" at url "' + self.target.uri.href + '" does not correctly check anti csrf tokens. An anti CSRF token from a session was succesfuly used in another session.', true);
}
callback();
});
}, function (err) {
self._handleError(err);
done();
});
} else {
done();
return;
}
});
});
}
else {
done();
return;
}
});
}
/**
* Opens a new session and get Input Vectors from this.target
* @param cancellationToken
* @param callback - called with and array of input vectors : callback(inputVectorArray)
*/
getAnotherToken(cancellationToken, callback) {
let autoLogin = new AutoLogin();
var self = this;
var loginPage = url.resolve(this.target.uri, params.loginPage);
autoLogin.login(loginPage, params.user, params.password, cancellationToken, (err, data) => {
if (err) {
callback(err);
return;
}
request.get({ url: self.target.uri, timeout: 10000, cancellationToken: cancellationToken, jar: data.cookieJar }, (err, res, body) => {
/* istanbul ignore if */
Iif (err) {
callback(err);
return;
}
if (res.statusCode !== 200) {
callback(); // nothing to do
return;
}
let ivs = inputVector.parseHtml(body); // list of forms
callback(ivs);
});
});
}
/**
* Finds and returns the anti csrf field of an input vector.
* If no anti csrf token, returns null.
* @param inputVector
*/
getCsrfField(inputVector) {
if (!inputVector) return null;
if (inputVector.fields.length <= 0) return null;
// obvious patterns
// if a field matches, the field is returned without looking at other fields
let regexTokens = [/csrf/i,
/xsrf/i,
/\[_token\]/, // Symfony 2.x
/form_key/, // Magento 1.9
/nonce/, // e.g. WordPress
];
for (let field of inputVector.fields) {
if (field.type == 'hidden') {
for (let r of regexTokens) {
if (field.name.match(r)) {
return field;
}
}
}
}
// not so obvious patterns
// if a field is the only one to match, return it (if multiple fields match, we can't determine which one is the csrf token)
let notObviousRegexTokens = [/^token/i, /token$/i];
let fieldName = [];
let ret = null;
for (let field of inputVector.fields) {
if (field.type == 'hidden') {
for (let r of notObviousRegexTokens) {
if (field.name.match(r)) {
if (fieldName.indexOf(field.name) == -1) {
fieldName.push(field.name);
ret = field;
}
}
}
}
}
if (fieldName.length == 1) return ret;
return null;
}
};
|